fix(core): preserve configured Git HTTPS CA bundles during vendored auth flows - #68
Merged
Merged
Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
preserve configured Git CA bundle while enforcing ssl_verify during vendoring and publish for authenticated HTTPS package cloning
What Changed
akua-coreGit/HTTPS fetch paths to preserve user-configured CA settings while keeping TLS verification behavior explicit, including authenticated vendoring/publish-related flows where previously CA handling could be lost.crates/akua-core/tests/vendor_https_auth.rsplus transport-level validation (git_transport_backend) to assert CA bundle preservation through HTTPS clone/fetch workflows..github/workflows/ci.yml,docs/cli.md,docs/sdk.md,site/cli/vendor.html,site/concepts/sdk.html,CHANGELOG.md,docs/security-audit-2026-05-29.md) to reflect and validate the HTTPS CA-preservation behavior.Risk Assessment
✅ Low: The patch is a focused security hardening plus regression test addition and does not reveal a clearly material correctness or security regression in the changed paths from static inspection.
Testing
Executed three targeted test runs and confirmed all three tests passed; the dedicated HTTPS auth test showed verification is still enforced while using configured CA data (and rejecting ambient header leakage), and the publish round-trip test passed, demonstrating the vendored dependency publish path remains functional under the same TLS-safe resolver stack.
Evidence: HTTPS vendor/auth test transcript
Evidence: Publish-roundtrip regression test transcript
Evidence: Git transport backend test transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
cargo test -p akua-core vendor_add_forces_verification_and_preserves_environment_ca_bundle --test vendor_https_auth -- --exact --nocapturecargo test -p akua-core publish_then_pull_then_render_offline --test vendor_roundtrip -- --exact --nocapturecargo test -p akua-core git_fetch_uses_curl_transport_for_tls_configuration --test git_transport_backend -- --exact --nocapture✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.