diff --git a/AGENTS.md b/AGENTS.md index a9f87946d..8fb28664e 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -18,6 +18,7 @@ ## Conventions + Style - Avoid defensive code that adds complexity without a clear, likely payoff. +- Avoid introducing local variables that are only used once or twice when inlining keeps the code clear. ## Response format diff --git a/Cargo.lock b/Cargo.lock index 0c326017a..817d31925 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1266,7 +1266,6 @@ dependencies = [ "rustc-hash", "serde", "serde_json", - "serde_millis", "testing_logger", "thiserror", "tracing", @@ -1553,15 +1552,6 @@ dependencies = [ "serde_core", ] -[[package]] -name = "serde_millis" -version = "0.1.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e6e2dc780ca5ee2c369d1d01d100270203c4ff923d2a4264812d723766434d00" -dependencies = [ - "serde", -] - [[package]] name = "sha2" version = "0.10.9" diff --git a/Cargo.toml b/Cargo.toml index 81b6d2e92..e49fe5932 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -152,7 +152,6 @@ lazy_static = "1.5.0" serde = { workspace = true } tracing-subscriber = "0.3.23" tracing = "0.1.44" -serde_millis = "0.1.1" [build-dependencies] chrono = { workspace = true, features = ["now"], optional = true } diff --git a/infra/nightly-resources/web/index.js b/infra/nightly-resources/web/index.js index 5920fbf56..0f97ae26d 100644 --- a/infra/nightly-resources/web/index.js +++ b/infra/nightly-resources/web/index.js @@ -17,7 +17,7 @@ async function load() { const response = await fetch("./data/data.json"); if (!response.ok) { - statusNode.textContent = `Failed to load data/data.json: ${error}`; + statusNode.textContent = `Failed to load data/data.json: ${response.status} ${response.statusText}`; return; } diff --git a/infra/nightly.py b/infra/nightly.py index a26ceeb67..30166c93c 100644 --- a/infra/nightly.py +++ b/infra/nightly.py @@ -1,4 +1,4 @@ -#!/user/bin/env python3 +#!/usr/bin/env python3 import json import subprocess @@ -40,7 +40,7 @@ def run_command(cmd, summary_fn): time_micros = (time.perf_counter_ns() - started) // 1000 if cmd_result.returncode != 0: return { - "cmd": cmd, + "cmd": " ".join(cmd), "status": "error", "wall_time_micros": time_micros } @@ -154,7 +154,6 @@ def run_benchmarks(benchmark_dir): ] train_result = run_command(train_command, summarize_train_report) if train_result["status"] == "success": - print(f"Train Success: {benchmark_name}") report["train"] = train_result else: print(f"Failure: {benchmark_name}") @@ -172,7 +171,6 @@ def run_benchmarks(benchmark_dir): serve_result = run_command(serve_command, summarize_serve_report) if serve_result["status"] == "success": - print(f"Serve Success: {benchmark_name}") report["serve"] = serve_result reports.append(report) else: @@ -185,4 +183,4 @@ def run_benchmarks(benchmark_dir): if len(sys.argv) != 2: raise SystemExit(f"Usage: nightly.py ") - main(sys.argv[1]) \ No newline at end of file + main(sys.argv[1]) diff --git a/tests/passing/include.egg b/tests/skipped/include.egg similarity index 100% rename from tests/passing/include.egg rename to tests/skipped/include.egg