feat: add agent availability roles#31
Merged
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
requested changes
May 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
The new authorization check is in the right place conceptually, but there is a blocking fallback that bypasses agent initiation enforcement when the identity client is unavailable. Requesting changes to fail loudly instead of allowing the request.
Contributor
Author
|
Addressed Noa's requested changes:
Validation:
|
noa-lucent
approved these changes
May 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The identity-client nil fallback now fails loudly, tests were updated to cover the path, and CI is passing. Approved.
noa-lucent
approved these changes
May 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Refreshed at head 1d6cccc. The previous issue remains resolved and CI is passing. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes agynio/agents#51