From e1e51316443b2ad8f655c2d213a0c069c1c7e67f Mon Sep 17 00:00:00 2001 From: Vincent Fretin Date: Sat, 13 Dec 2025 14:50:04 +0100 Subject: [PATCH 1/2] Remove useless lines in tracked-controls component, those should have been removed when tracked-controls-webxr was renamed to tracked-controls in https://github.com/aframevr/aframe/commit/627698d4bd00e055549c0b91573a66f721d8dfef --- src/components/tracked-controls.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/components/tracked-controls.js b/src/components/tracked-controls.js index 0f5761ee91f..934245ba208 100644 --- a/src/components/tracked-controls.js +++ b/src/components/tracked-controls.js @@ -36,8 +36,8 @@ export var Component = registerComponent('tracked-controls', { init: function () { this.buttonEventDetails = {}; - this.buttonStates = this.el.components['tracked-controls'].buttonStates = {}; - this.axis = this.el.components['tracked-controls'].axis = [0, 0, 0]; + this.buttonStates = {}; + this.axis = [0, 0, 0]; this.changedAxes = []; this.axisMoveEventDetail = {axis: this.axis, changed: this.changedAxes}; @@ -80,8 +80,6 @@ export var Component = registerComponent('tracked-controls', { this.data.iterateControllerProfiles, this.data.handTrackingEnabled ); - // Legacy handle to the controller for old components. - this.el.components['tracked-controls'].controller = this.controller; }, tick: function () { From bbb550ed1534df0316b324ae471ec895cc2e72c2 Mon Sep 17 00:00:00 2001 From: Vincent Fretin Date: Mon, 15 Dec 2025 11:02:45 +0100 Subject: [PATCH 2/2] Rename tracked-controls-webxr to tracked-controls in the warning message --- src/components/hand-tracking-controls.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/hand-tracking-controls.js b/src/components/hand-tracking-controls.js index 81ba056b863..65c8de755d4 100644 --- a/src/components/hand-tracking-controls.js +++ b/src/components/hand-tracking-controls.js @@ -149,7 +149,7 @@ export var Component = registerComponent('hand-tracking-controls', { xrSession.requestReferenceSpace(referenceSpaceType).then(function (referenceSpace) { self.referenceSpace = referenceSpace; }).catch(function (error) { - self.el.sceneEl.systems.webxr.warnIfFeatureNotRequested(referenceSpaceType, 'tracked-controls-webxr uses reference space ' + referenceSpaceType); + self.el.sceneEl.systems.webxr.warnIfFeatureNotRequested(referenceSpaceType, 'tracked-controls uses reference space ' + referenceSpaceType); throw error; }); },