From fefe5d81ee58fb0d855b9bdf1a4f788720497f09 Mon Sep 17 00:00:00 2001 From: Rob Rusher Date: Tue, 22 Oct 2024 16:45:21 -0600 Subject: [PATCH 1/2] move fetch nav to eager scripts --- blocks/header/header.js | 2 +- scripts/scripts.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/blocks/header/header.js b/blocks/header/header.js index 1ea6b4c6..27611d78 100644 --- a/blocks/header/header.js +++ b/blocks/header/header.js @@ -426,7 +426,7 @@ export default async function decorate(block) { : `${PATH_PREFIX}/${langCode}/nav`; const fragment = await loadFragment(navPath); const placeholdersData = await fetchLanguagePlaceholders(); - fetchLanguageNavigation(`/${langCode}`); + // fetchLanguageNavigation(`/${langCode}`); moved to eager in scripts.js // decorate nav DOM block.textContent = ''; diff --git a/scripts/scripts.js b/scripts/scripts.js index e7f4796d..6da6b15b 100644 --- a/scripts/scripts.js +++ b/scripts/scripts.js @@ -22,6 +22,7 @@ import { setPageLanguage, cookiePopUp, showCookieConsent, + fetchLanguageNavigation, PATH_PREFIX, } from './utils.js'; @@ -239,6 +240,7 @@ export async function load404() { async function loadEager(doc) { setPageLanguage(); decorateTemplateAndTheme(); + fetchLanguageNavigation(`/${getLanguage()}`); await createSkipToMainNavigationBtn(); await cookiePopUp(); renderWBDataLayer(); From 917491f7d56259796b44f304d747303e3fe94b40 Mon Sep 17 00:00:00 2001 From: Rob Rusher Date: Tue, 22 Oct 2024 17:06:47 -0600 Subject: [PATCH 2/2] clean up --- blocks/header/header.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/blocks/header/header.js b/blocks/header/header.js index 27611d78..835dcb21 100644 --- a/blocks/header/header.js +++ b/blocks/header/header.js @@ -10,7 +10,7 @@ import { fetchLangDatabyFileName, } from '../../scripts/scripts.js'; import { - getLanguage, PATH_PREFIX, fetchLanguageNavigation, + getLanguage, PATH_PREFIX, } from '../../scripts/utils.js'; import * as constants from './constants.js'; import { @@ -426,7 +426,6 @@ export default async function decorate(block) { : `${PATH_PREFIX}/${langCode}/nav`; const fragment = await loadFragment(navPath); const placeholdersData = await fetchLanguagePlaceholders(); - // fetchLanguageNavigation(`/${langCode}`); moved to eager in scripts.js // decorate nav DOM block.textContent = '';