From 2b7baf4602c0ec88d036690665a960c9d630d5c4 Mon Sep 17 00:00:00 2001 From: Piyush Jindal Date: Tue, 21 Jan 2025 22:26:31 +0530 Subject: [PATCH 1/2] assessibility fix --- blocks/header/nav.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/blocks/header/nav.js b/blocks/header/nav.js index 9ff97f20..6914e0c9 100644 --- a/blocks/header/nav.js +++ b/blocks/header/nav.js @@ -410,8 +410,8 @@ export default async function decorate(block) { form({ class: 'search-form', action: `/${locale}/search`, method: 'get', autocomplete: 'off' }, label({ for: 'siteSearch' }, 'Search Query'), input({ id: 'siteSearch', type: 'text', placeholder: 'Search', name: 'searchQuery', tabindex: '-1' }), - a({ class: 'search-button', type: 'submit', 'aria-label': 'Search' }), - a({ class: 'close', type: 'button', 'aria-label': 'Close' }), + a({ class: 'search-button', 'aria-label': 'Search', role: 'button', href: '#' }), + a({ class: 'close', href: '#', role: 'button', 'aria-label': 'Close' }), ), ), ); @@ -421,7 +421,7 @@ export default async function decorate(block) { navSearch.querySelector('a').setAttribute('aria-controls', 'nav-search-popup'); navSearch.querySelector('div').setAttribute('id', 'nav-search-popup'); - const navLocate = div({ class: 'nav-locate', id: 'nav-locate', 'aria-expanded': false }, + const navLocate = div({ class: 'nav-locate', id: 'nav-locate', 'aria-expanded': false, role: 'button' }, a({ href: '#', title: 'Find Your Service Center', 'aria-controls': 'nav-locate' }, 'Find Your Service Center'), div({ class: 'locate-popup' }, span('Find Yours:'), From fb79ec9d7341ce560a922a0d425bc1b59fdb7ae0 Mon Sep 17 00:00:00 2001 From: Piyush Jindal Date: Wed, 22 Jan 2025 21:14:16 +0530 Subject: [PATCH 2/2] Review comments fix --- blocks/header/nav.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/blocks/header/nav.js b/blocks/header/nav.js index 6914e0c9..9fea57d0 100644 --- a/blocks/header/nav.js +++ b/blocks/header/nav.js @@ -410,8 +410,8 @@ export default async function decorate(block) { form({ class: 'search-form', action: `/${locale}/search`, method: 'get', autocomplete: 'off' }, label({ for: 'siteSearch' }, 'Search Query'), input({ id: 'siteSearch', type: 'text', placeholder: 'Search', name: 'searchQuery', tabindex: '-1' }), - a({ class: 'search-button', 'aria-label': 'Search', role: 'button', href: '#' }), - a({ class: 'close', href: '#', role: 'button', 'aria-label': 'Close' }), + a({ class: 'search-button', role: 'button', 'aria-label': 'Search' }), + a({ class: 'close', role: 'button', 'aria-label': 'Close' }), ), ), );