DO NOT MERGE: measure pool_peak_bytes reproducibility - #16
Open
adriangb wants to merge 1 commit into
Open
Conversation
Comment-only, so both sides of the comparison compile identically.
Owner
Author
|
run benchmark tpch [pool-peak reproducibility 1/2] AFTER — per-iteration readingsBoth sides carry apache#24023 and differ only by a comment, soevery pool-peak difference below is measurement noise.The memory limit is what installs the recording pool: without one,pool_peak_bytes is omitted and no memory table is rendered at all.env: |
Owner
Author
|
run benchmark tpch [pool-peak reproducibility 2/2] BEFORE — max-over-iterationsBoth sides pinned to a589b4b, the commit apache#24023 branches from, so this isthe same A/A measurement taken against the unpatched reading. Compare thespread in this memory table against 1/2.env: |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing bench/pool-peak-noop-check (f91a869) to 1ae6b87 (merge-base) diff Run configurationrun benchmark tpch
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing a589b4b (a589b4b) to a589b4b diff Run configurationrun benchmark tpch
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G"
baseline:
ref: "a589b4bbae"
changed:
ref: "a589b4bbae"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing bench/pool-peak-noop-check (f91a869) to 1ae6b87 (merge-base) diff Run configurationrun benchmark tpch
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G"CPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing a589b4b (a589b4b) to a589b4b diff Run configurationrun benchmark tpch
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G"
baseline:
ref: "a589b4bbae"
changed:
ref: "a589b4bbae"CPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
Owner
Author
|
run benchmark tpch [pool-peak reproducibility 1/2, corrected] AFTER — per-iteration readingsThe first attempt at this run was not an A/A: the runner resolves thebaseline as
|
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing 59bb7b2 (59bb7b2) to 59bb7b2 diff Run configurationrun benchmark tpch
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G"
baseline:
ref: "59bb7b2e77"
changed:
ref: "59bb7b2e77"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing 59bb7b2 (59bb7b2) to 59bb7b2 diff Run configurationrun benchmark tpch
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G"
baseline:
ref: "59bb7b2e77"
changed:
ref: "59bb7b2e77"CPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only change on top of bench/pool-peak-per-iteration (apache#24023). Both sides compile to identical code, so every reported difference is measurement noise. Requires DATAFUSION_RUNTIME_MEMORY_LIMIT to be set, since the recording pool is only installed alongside a pool that has a limit.