From 403f25540d417f31c8e9b42e64b9dae14de9735e Mon Sep 17 00:00:00 2001 From: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> Date: Tue, 9 Jun 2026 07:30:09 -0500 Subject: [PATCH] Add predicate_eval to standard benchmark allowlist predicate_eval is a bench.sh standard benchmark (`bench.sh run predicate_eval`): conjunctive (AND) filter-evaluation micro-benchmarks backed by the sql_benchmarks/predicate_eval query set, with subgroups that exercise adaptive predicate ordering. It was missing from the standard allowlist, so `run benchmark predicate_eval` fell through to the wildcard criterion path and ran `cargo bench --bench predicate_eval`, which has no such target and failed. Adding it to the standard list routes it to the bench.sh runner. Co-Authored-By: Claude Opus 4.8 (1M context) --- README.md | 1 + services/controller.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 7dc4273..5f0631b 100644 --- a/README.md +++ b/README.md @@ -161,6 +161,7 @@ show benchmark queue | `sort_pushdown_inexact_unsorted` | Sort pushdown inexact unsorted | | `sort_pushdown_inexact_overlap` | Sort pushdown inexact overlap | | `wide_schema` | Wide-schema parquet metadata overhead (1024 cols × 256 files; wide vs narrow) | +| `predicate_eval` | Conjunctive (AND) filter-evaluation micro-benchmarks; subgroups exercise adaptive predicate ordering | ### DataFusion (criterion) diff --git a/services/controller.ts b/services/controller.ts index 7a50f02..5dab562 100644 --- a/services/controller.ts +++ b/services/controller.ts @@ -201,7 +201,7 @@ export const controllerStatefulSet = new k8s.apps.v1.StatefulSet("benchmark-cont "external_aggr", "tpcds", "smj", "sort_pushdown", "sort_pushdown_sorted", "sort_pushdown_inexact", "sort_pushdown_inexact_unsorted", "sort_pushdown_inexact_overlap", - "wide_schema", + "wide_schema", "predicate_eval", ], default_standard: [ "clickbench_partitioned", "tpcds", "tpch", @@ -217,7 +217,7 @@ export const controllerStatefulSet = new k8s.apps.v1.StatefulSet("benchmark-cont "external_aggr", "tpcds", "smj", "sort_pushdown", "sort_pushdown_sorted", "sort_pushdown_inexact", "sort_pushdown_inexact_unsorted", "sort_pushdown_inexact_overlap", - "wide_schema", + "wide_schema", "predicate_eval", ], default_standard: [ "clickbench_partitioned", "tpcds", "tpch",