[Bug] Cannot open some msi files

[redsigma]

Describe the bug

I tried extracting the .msi file at this link
https://ftp.mozilla.org/pub/thunderbird/releases/152.0b3/win64/en-US/Thunderbird%20Setup%20152.0b3.msi

Howver it doesnt seem to show anything in the Extract Files tab

To Reproduce
Steps to reproduce the behavior:

1. Download msi from https://ftp.mozilla.org/pub/thunderbird/releases/152.0b3/win64/en-US/Thunderbird%20Setup%20152.0b3.msi
2. Drag and drop it into less miserables
3. Nothing shows in the extract files

Expected behavior
I should be able to see the files that i can extract

Screenshots

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.Exception: Failed to open cabinet. Last error:MSPACK_ERR_DATAFORMAT
   at LibMSPackN.MSCabinet..ctor(String cabinetFilename)
   at LessMsi.Gui.MainFormPresenter.OnSelectedStreamChanged()
   at LessMsi.Gui.MainForm.cboStream_SelectedValueChanged(Object sender, EventArgs e)
   at System.Windows.Forms.ListControl.OnSelectedValueChanged(EventArgs e)
   at System.Windows.Forms.ComboBox.OnSelectedValueChanged(EventArgs e)
   at System.Windows.Forms.ComboBox.OnSelectedIndexChanged(EventArgs e)
   at System.Windows.Forms.ComboBox.WmReflectCommand(Message& m)
   at System.Windows.Forms.ComboBox.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll
----------------------------------------
lessmsi-gui
    Assembly Version: 2.12.9.0
    Win32 Version: 2.12.9
    CodeBase: file:///E:/Apps/tools/lessmsi/lessmsi-gui.exe
----------------------------------------
System.Windows.Forms
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4360.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Core
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------
System.Configuration
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4190.0 built by: NET48REL1LAST_B
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Xml
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4084.0 built by: NET48REL1
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.8.4084.0 built by: NET48REL1
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
LessIO
    Assembly Version: 1.0.34.0
    Win32 Version: 1.0.34
    CodeBase: file:///E:/Apps/tools/lessmsi/LessIO.DLL
----------------------------------------
lessmsi.core
    Assembly Version: 2.12.9.0
    Win32 Version: 2.12.9
    CodeBase: file:///E:/Apps/tools/lessmsi/lessmsi.core.DLL
----------------------------------------
wix
    Assembly Version: 2.0.2110.0
    Win32 Version: 2.0.2110.0
    CodeBase: file:///E:/Apps/tools/lessmsi/wix.DLL
----------------------------------------
WindowsBase
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/WindowsBase/v4.0_4.0.0.0__31bf3856ad364e35/WindowsBase.dll
----------------------------------------
libmspackn
    Assembly Version: 0.9.10.0
    Win32 Version: 0.9.10
    CodeBase: file:///E:/Apps/tools/lessmsi/libmspackn.DLL
----------------------------------------
Accessibility
    Assembly Version: 4.0.0.0
    Win32 Version: 4.8.4084.0 built by: NET48REL1
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Desktop (please complete the following information):

• OS: Windows
• Browser: Firefox
• Version 150.0

[mega5800]

Hi @redsigma.
Thank you for opening this ticket.

Let me check what's going on here during the weekend.

Thanks.

[mega5800]

Hi @activescott,
I debugged this issue and apparently we are failing to get the contained rows inside the Thunderbird Setup 152.0b3.msi database.

I've pinpointed the issue to this method in MsiFile.cs:
public static MsiFile[] CreateMsiFilesFromMSI(Database msidb)

This is the result of using the provided Thunderbird Setup 152.0b3.msi file:

And here is is the result of using another MSI file I have:

What can we do in such a situation?

Thanks.

[redsigma]

Maybe the contents is in another table and not "File" . Maybe that setup.cab is some binary data that has the files , since it throws that exception when i select it,

[activescott]

@mega5800 Looks strange. I'm not sure why the File table would be empty that is a pretty core table to windows installer files: https://learn.microsoft.com/en-us/windows/win32/msi/file-table

Does it also appear empty on the Table View tab?

Also the stack from OP looks a bit different. It's in LibMSPackN.MSCabinet..ctor(String cabinetFilename) which, I'd guess is more likely to be vulnerable. I do have a branch around somewhere with some fixes for that code too.

[ibay613]

having the same issue with Chrome enterprise here: https://dl.google.com/tag/s/appguid%3D%7B8237E44A-0054-442C-B6B6-EA0509993955%7D%26iid%3D%7BAC341C9B-F779-49E9-ACB7-BEACC007AD64%7D%26browser%3D4%26usagestats%3D0%26appname%3DGoogle%2520Chrome%2520Beta%26needsadmin%3Dtrue%26ap%3D-arch_x64-statsdef_0%26brand%3DGCEA/dl/chrome/install/beta/googlechromebetastandaloneenterprise64.msi

Seeing the following in table view:
Property (s72) Value (l0)
ALLUSERS 1
ARPPRODUCTICON icon.ico
ARPNOMODIFY 1
AllowDowngradeSubstitution false
Manufacturer Google LLC
ProductCode {C3EDC6D8-AD56-3E8F-AD99-D0DA9882AB98}
ProductLanguage 1033
ProductName Google Chrome Beta
ProductVersion 150.0.7871.4
UpgradeCode {4E5BAC76-2D99-356C-AE5B-B15DA0315002}
SecureCustomProperties NEWPRODUCTFOUND;RUNFORCEINSTALL;UPGRADEFOUND

I managed to extract it with uniextract but it took like drilling through 9 folders to get what I needed too. Much appreciated for making and maintaining this.