From 86d83f126d3d45d9157d2b1183d015eaf5237b20 Mon Sep 17 00:00:00 2001 From: Thomas Sapelza Date: Fri, 26 Jun 2026 11:07:47 +0200 Subject: [PATCH 1/2] remove `@CheckReturnValue` from terminal operations --- .../testing/testdata/base/AllTestDataReader.java | 10 +++++----- .../testing/testdata/base/TestDataCreator.java | 5 ----- .../springboot/testing/web/request/Request.java | 7 ------- 3 files changed, 5 insertions(+), 17 deletions(-) diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/AllTestDataReader.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/AllTestDataReader.java index d2220bc..622ef17 100644 --- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/AllTestDataReader.java +++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/AllTestDataReader.java @@ -25,7 +25,6 @@ public List returnAll() { @SafeVarargs @SuppressWarnings("unused") - @CheckReturnValue public final List returnSorted(Comparator... comparators) { if (comparators.length == 0) { throw new IllegalArgumentException("At least one comparator must be provided"); @@ -41,7 +40,6 @@ public final List returnSorted(Comparator... comparators) { @SafeVarargs @SuppressWarnings({"unchecked", "unused"}) - @CheckReturnValue public final > List returnSorted(Function>... comparators) { if (comparators.length == 0) { throw new IllegalArgumentException("At least one comparator must be provided"); @@ -56,7 +54,6 @@ public final > List returnSorted(Function< } @SuppressWarnings("unused") - @CheckReturnValue public > AllAndFiltered returnFiltered(Predicate predicate) { var all = this.returnAll(); return new AllAndFiltered<>( @@ -74,7 +71,10 @@ public Set returnSet() { protected abstract List fetch(); - public record AllAndFiltered(List all, List filtered, List other) { - + public record AllAndFiltered( + List all, + List filtered, + List other + ) { } } diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java index 6147b34..855c5ce 100644 --- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java +++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java @@ -29,20 +29,17 @@ public void commit() { } @SuppressWarnings("unused") - @CheckReturnValue public ITEM returnFirst() { return create().getFirst(); } @SuppressWarnings("unused") - @CheckReturnValue public List returnAll() { return create(); } @SafeVarargs @SuppressWarnings("unused") - @CheckReturnValue public final List returnSorted(Comparator... comparators) { if (comparators.length == 0) { throw new IllegalArgumentException("At least one comparator must be provided"); @@ -58,7 +55,6 @@ public final List returnSorted(Comparator... comparators) { @SafeVarargs @SuppressWarnings({"unchecked", "unused"}) - @CheckReturnValue public final > List returnSorted(Function>... comparators) { if (comparators.length == 0) { throw new IllegalArgumentException("At least one comparator must be provided"); @@ -73,7 +69,6 @@ public final > List returnSorted(Function< } @SuppressWarnings("unused") - @CheckReturnValue public Set returnSet() { return new HashSet<>(create()); } diff --git a/src/main/java/it/aboutbits/springboot/testing/web/request/Request.java b/src/main/java/it/aboutbits/springboot/testing/web/request/Request.java index 88a5b86..af26443 100644 --- a/src/main/java/it/aboutbits/springboot/testing/web/request/Request.java +++ b/src/main/java/it/aboutbits/springboot/testing/web/request/Request.java @@ -127,7 +127,6 @@ public Request basicAuth(String username, String password) { @SneakyThrows(UnsupportedEncodingException.class) @SuppressWarnings("unused") - @CheckReturnValue public ItemResponse returnItem(Class clazz) { var res = _execute(); @@ -146,7 +145,6 @@ public ItemResponse returnItem(Class clazz) { @SneakyThrows(UnsupportedEncodingException.class) @SuppressWarnings("unused") - @CheckReturnValue public ItemResponseWithMeta returnItem( Class clazz, Class metaClass @@ -168,7 +166,6 @@ public ItemResponseWithMeta returnItem( @SneakyThrows(UnsupportedEncodingException.class) @SuppressWarnings("unused") - @CheckReturnValue public ListResponse returnList(Class clazz) { var res = _execute(); @@ -187,7 +184,6 @@ public ListResponse returnList(Class clazz) { @SneakyThrows(UnsupportedEncodingException.class) @SuppressWarnings("unused") - @CheckReturnValue public PagedResponse returnPage(Class clazz) { var res = _execute(); @@ -206,7 +202,6 @@ public PagedResponse returnPage(Class clazz) { @SneakyThrows(UnsupportedEncodingException.class) @SuppressWarnings("unused") - @CheckReturnValue public T returnCustom(Class clazz) { var res = _execute(); @@ -222,7 +217,6 @@ public T returnCustom(Class clazz) { @SneakyThrows(UnsupportedEncodingException.class) @SuppressWarnings("unused") - @CheckReturnValue public ErrorResponse returnError() { var res = _execute(); @@ -237,7 +231,6 @@ public ErrorResponse returnError() { } @SuppressWarnings("unused") - @CheckReturnValue public ResultActions returnRaw() { return _execute(); } From 9ac573d12375762739045a74b35c36a5f78f493c Mon Sep 17 00:00:00 2001 From: Thomas Sapelza Date: Fri, 26 Jun 2026 11:10:12 +0200 Subject: [PATCH 2/2] remove unused import which makes Checkstyle happy --- .../springboot/testing/testdata/base/TestDataCreator.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java index 855c5ce..96287dd 100644 --- a/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java +++ b/src/main/java/it/aboutbits/springboot/testing/testdata/base/TestDataCreator.java @@ -1,6 +1,5 @@ package it.aboutbits.springboot.testing.testdata.base; -import com.google.errorprone.annotations.CheckReturnValue; import it.aboutbits.springboot.testing.testdata.FakerExtended; import org.jspecify.annotations.NullMarked;