From d2f8f7bb9d4e56d7a32cba88847cfa8176f2fc2d Mon Sep 17 00:00:00 2001 From: Mark Scala Date: Sun, 19 Apr 2026 13:30:47 -0600 Subject: [PATCH] ace-window.el (aw-make-frame): Fix height using cdr of aw-frame-size The height parameter was incorrectly using (car aw-frame-size), the width component, instead of (cdr aw-frame-size). This caused any explicit height value to be silently ignored, with the width value used in its place. Also correct the aw-frame-size docstring: the units are characters and text lines (as documented by make-frame), not pixels. --- ace-window.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ace-window.el b/ace-window.el index ccb2783..239f909 100644 --- a/ace-window.el +++ b/ace-window.el @@ -142,8 +142,10 @@ Its value is an (x-offset . y-offset) pair in pixels." (defcustom aw-frame-size nil "Frame size to make new ace-window frames. -Its value is a (width . height) pair in pixels or nil for the default frame size. -(0 . 0) is special and means make the frame size the same as the last selected frame size." +Its value is a (width . height) pair, where width is in characters and +height is in text lines, as passed to `make-frame'. Nil means use the +default frame size. (0 . 0) means match the size of the currently +selected frame." :type '(cons integer integer)) (defcustom aw-char-position 'top-left @@ -467,7 +469,7 @@ LEAF is (PT . WND)." (cons 'height (if (zerop (cdr aw-frame-size)) (frame-height) - (car aw-frame-size)))) + (cdr aw-frame-size)))) (cons 'left (+ (car aw-frame-offset) (car (frame-position)))) (cons 'top (+ (cdr aw-frame-offset)