Shell completion seems to work in fish without installation

[injust]

I installed the shell completion into fish by following https://abhinav.github.io/git-spice/setup/shell/#fish, then tested the example command gs branch onto tab.

The completion results seem like they're identical, whether or not I have the shell completion installed. Am I missing something here?

[abhinav]

@injust How did you install git-spice?
If you used brew install git-spice, note that Homebrew does that setup for you.
(We can probably mention that in the docs if that's the case.)

[injust]

Yup, I did brew install git-spice. Everything makes sense now!

[mcepl]

However, the original reporter is right that

eval "$(gs shell completion fish)"

is not a correct fish syntax. And I am not sure what is right:

mitmanek~/r/p/python-lsp-server (orjson)$ git spice shell completion fish
function __complete_git-spice
    set -lx COMP_LINE (commandline -cp)
    test -z (commandline -ct)
    and set COMP_LINE "$COMP_LINE "
    /usr/libexec/git/git-spice
end
complete -f -c git-spice -a "(__complete_git-spice)"
mitmanek~/r/p/python-lsp-server (orjson)$ eval (git spice shell completion fish)
fish: Expected end of the statement, but found end of the input

mitmanek~/r/p/python-lsp-server (orjson)$ 

[abhinav]

What version of fish are you using?
I don't use fish, but installing the latest version, this works as expected:

> fish --version
fish, version 4.3.2

> gs [tab]
[no git-spice completion]

> eval "$(gs shell completion fish)"
> gs [tab]
auth    down       repo   trunk    --dir        --verbose
bottom  downstack  shell  up       --help       --version
branch  log        stack  upstack  --no-prompt
commit  rebase     top    version  --prompt

If there's some nuance around configuring fish completions that I'm missing here, I'll be happy to update the docs, but this definitely works.

[injust]

@mcepl The problem is you are running:

eval (gs shell completion fish)

Instead of:

eval "$(gs shell completion fish)"

I changed git spice to gs in the examples, but use what works for you.

[mcepl]

Yes, that's correct. Thank you. And yes, I also use git spice (https://build.opensuse.org/package/show/home:mcepl/git-spice) because of the conflict with Ghostscript.