#2671

[adluu2k1]

pygments#2671

[ZuxingGit]

JavaScript: before vs after


TypeScript: before vs after

[ZuxingGit]

Semicolon is added to the end of line, which is different from the issue's sample code. Should I delete it when testing?

[adluu2k1]

Semicolon is not important in JS, I believe. But yes, you should delete it since we need the test code to be the same as the code in the original issue

[ZuxingGit]

JavaScript: before vs after

TypeScript: before vs after

[trungtruong1]

@ZuxingGit Hi, is the fix for the issue complete?

[ZuxingGit]

@ZuxingGit Hi, is the fix for the issue complete?

I will test it using Ishaan's method today. #3

[ZuxingGit]

So, I guess it passed all

[adluu2k1]

In case you misunderstand how the command in Ishaan's method works. It doesn't check correctness of the output and, instead, it overwrite the old output with the one resulted from the current code (mind the --update-goldens option). Using Ishaan's method, you can check whether the sample code is highlighted correctly by looking at what is returned in the area in question.