Skip to content

Undo/redo: no onEditCommit round-trip, and stack granularity is per-keystroke #62

Description

@zvndev

Problem (two related issues)

  1. undo()/redo() (with enableUndoRedo) only call the internal setPendingValue(oldValue) and emit undo/redo events — they never fire onEditCommit. For external-state grids a revert never reaches the data source, and cells rendering from row.original don't even show it.
  2. The undo stack pushes one action per setPendingValue call, and CellInput calls that on every keystroke — so undoing a typed edit walks back character by character instead of one action per committed edit.

Expected

One user edit = one undo step, and undo/redo re-emit through onEditCommit (with the old value) so external stores stay in sync.

Impact

Any store-backed grid can't ship undo/redo at all — the buttons would visually do nothing or half-work.

Versions: yable-react 0.10.4 / yable-core 0.9.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions