Problem (two related issues)
undo()/redo() (with enableUndoRedo) only call the internal setPendingValue(oldValue) and emit undo/redo events — they never fire onEditCommit. For external-state grids a revert never reaches the data source, and cells rendering from row.original don't even show it.
- The undo stack pushes one action per
setPendingValue call, and CellInput calls that on every keystroke — so undoing a typed edit walks back character by character instead of one action per committed edit.
Expected
One user edit = one undo step, and undo/redo re-emit through onEditCommit (with the old value) so external stores stay in sync.
Impact
Any store-backed grid can't ship undo/redo at all — the buttons would visually do nothing or half-work.
Versions: yable-react 0.10.4 / yable-core 0.9.0.
Problem (two related issues)
undo()/redo()(withenableUndoRedo) only call the internalsetPendingValue(oldValue)and emitundo/redoevents — they never fireonEditCommit. For external-state grids a revert never reaches the data source, and cells rendering fromrow.originaldon't even show it.setPendingValuecall, andCellInputcalls that on every keystroke — so undoing a typed edit walks back character by character instead of one action per committed edit.Expected
One user edit = one undo step, and undo/redo re-emit through
onEditCommit(with the old value) so external stores stay in sync.Impact
Any store-backed grid can't ship undo/redo at all — the buttons would visually do nothing or half-work.
Versions: yable-react 0.10.4 / yable-core 0.9.0.