Skip to content

Invalid width HTML attribute rendered in the snippet preview container #796

Description

@afercia

The snippet preview container has a width prop that gets rendered as a HTML attribute, producing invalid HTML Error: Attribute width not allowed on element div at this point.

<Container
onMouseLeave={ this.onMouseLeave }
width={ MAX_WIDTH + ( 2 * WIDTH_PADDING ) }
padding={ WIDTH_PADDING }
>

This prop gets then passed down to the desktop and mobile inner components. While it's a very minor thing, it would be great to not use prop names that match HTML attributes. Renaming it to something else would be enough to fix it.

screenshot 2018-12-14 at 10 31 53

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions