Skip to content

[BUG]: 999 Gal revives set to 0 on lobby reload #145

Description

@Zeta-Arcade

Installation Method

Gale

What happened?

(v73 / v1.5.4, unsure if this is fixed in newer versions, no mention in changelog since then)

Reloading a lobby (Or making it so 999 Gal is unlocked from the beginning) results in her revive count being set to 0. This is because, presumably, having "Company Moon Recharge" set to True means this value doesn't get a chance to be updated yet, as its waiting for a quota to be completed first.
This means having the upgrade force-unlocked at the start of a save file is useless for the first quota. It also means reloading lobbies (something you may have to do often depending on the size of pack, stability etc, or just for longer sessions) makes you lose all your revives.
The solutions i propose would be:

  1. Have an option to save her current revive count to the save file anytime the game saves, and then retrieve this value on a lobby reload. This does mean her "Scale Heal and Revive with Player Count" setting will be inaccurate, as the "new" lobby could have a different player count (E.g. 6 players when saving, reload with now just 2 players, and now those 2 players have 6 revives available), but this is still better than the current behaviour, and this issue will also fix as soon as you enter the next quota anyways.
  2. Whenever FIRST unlocked in the ship, set her revive count to the current player count, and keep updating this value each time someone joins/disconnects UNTIL you first land, that way her revive count is correctly scaled to the current lobby size when first starting with her

What did you do?

Set 999 Gal to be unlocked instantly (Such as with the UnlockOnStart mod), and see she has 0 revives
Reload a lobby, and see she has 0 revives

Version

v73

What OS are you running?

Windows 10

List of mods used

N/A

Relevant log output

N/A

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions