Skip to content

[request] Change the way Modulus deploys a Meteor App #235

Description

@mycyberacademy

Currently, if I upload a meteor source code to modulus, it does these tasks:

  • Install npm packages present in package.json file.
  • Demeteorize the app using specified meteor version in .meteor/release

The 2nd step includes installing meteor specific packages, the ones the project uses. If one of those packages makes changes to package.json file, meteor throws a message saying that changes to package.json was made, and meteor npm install needs to be done again.

As a result modulus script halts without success:

Your package.json has been updated. Please, run npm install in your project directory.
Conversion failed.

The meteor package who make those changes is called webpack:weback. Please change modulus script so it could notice it has to run npm install again and doesn't halt.

I tested this out with meteor 1.4.1.
This will fix #224 too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions