Use ! empty() in WP_Parser_Node::has_child()

JanJakes · JanJakes · commit c4aff56894ac · 2026-04-29T09:34:36.000+02:00
`! empty( $this->children )` short-circuits without calling `count()`, saving one function call per invocation. Co-authored-by: Adam Zieliński <adam@adamziel.com> Adapted from #376
diff --git a/packages/mysql-on-sqlite/src/parser/class-wp-parser-node.php b/packages/mysql-on-sqlite/src/parser/class-wp-parser-node.php
@@ -109,7 +109,7 @@ public function merge_fragment( $node ) {
 	 * @return bool True if this node has any child nodes or tokens, false otherwise.
 	 */
 	public function has_child(): bool {
-		return count( $this->children ) > 0;
+		return ! empty( $this->children );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public function merge_fragment( $node ) {`
`109`	`109`	`* @return bool True if this node has any child nodes or tokens, false otherwise.`
`110`	`110`	`*/`
`111`	`111`	`public function has_child(): bool {`
`112`		`- return count( $this->children ) > 0;`
	`112`	`+ return ! empty( $this->children );`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`/**`