Gallery Block: Fix equal column gallery image sizes#2534
Draft
mukeshpanchal27 wants to merge 2 commits into
Draft
Gallery Block: Fix equal column gallery image sizes#2534mukeshpanchal27 wants to merge 2 commits into
mukeshpanchal27 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/2449-gallery-block #2534 +/- ##
==============================================================
- Coverage 69.14% 69.13% -0.02%
==============================================================
Files 90 90
Lines 7723 7739 +16
==============================================================
+ Hits 5340 5350 +10
- Misses 2383 2389 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@westonruter I'd appreciate any initial feedback you can provide on the PR when you have a chance to take a look. |
Member
|
pr makes sense to me, it would be good to add some tests that demonstrate what it achieves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2449
Relevant Technical Choices
Ensure that the number of images added matches the Gallery block's configured column count.
How to Test
3.3.Before
After
In follow-up PR will fix the sizes for other column settings.
Use of AI Tools
N/A