%s %s
', - __( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' ), + esc_html__( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' ), $lang, - $chosen + esc_html( $chosen ) ); } From 36aa9f0cc684cdfa74076d1ad4ce70b495500ded Mon Sep 17 00:00:00 2001 From: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> Date: Fri, 11 Oct 2024 16:55:49 -0700 Subject: [PATCH 2/6] Ignore escaping hard-coded string --- hello.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hello.php b/hello.php index 2351dd8..a77a446 100644 --- a/hello.php +++ b/hello.php @@ -60,7 +60,7 @@ function hello_dolly() { printf( '%s %s
', esc_html__( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' ), - $lang, + $lang, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped esc_html( $chosen ) ); } From fec872e6fe63cbffe62e42d2db1c04b9fc47284d Mon Sep 17 00:00:00 2001 From: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> Date: Tue, 8 Oct 2024 16:50:26 -0700 Subject: [PATCH 3/6] Use preferred wp_rand Address PCP error for WordPress.WP.AlternativeFunctions.rand_mt_rand. --- hello.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hello.php b/hello.php index a77a446..32e3fe4 100644 --- a/hello.php +++ b/hello.php @@ -46,7 +46,7 @@ function hello_dolly_get_lyric() { $lyrics = explode( "\n", $lyrics ); // And then randomly choose a line. - return wptexturize( $lyrics[ mt_rand( 0, count( $lyrics ) - 1 ) ] ); + return wptexturize( $lyrics[ wp_rand( 0, count( $lyrics ) - 1 ) ] ); } // This just echoes the chosen line, we'll position it later. From d9bbfcee6e5c7d234587fd6a115e12a93e536510 Mon Sep 17 00:00:00 2001 From: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> Date: Thu, 24 Oct 2024 11:32:35 -0700 Subject: [PATCH 4/6] Add GPLv2 license info --- hello.php | 2 ++ readme.txt | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hello.php b/hello.php index 32e3fe4..927b22a 100644 --- a/hello.php +++ b/hello.php @@ -10,6 +10,8 @@ Author: Matt Mullenweg Version: 1.7.2 Author URI: http://ma.tt/ +License: GPLv2 or later +License URI: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html */ function hello_dolly_get_lyric() { diff --git a/readme.txt b/readme.txt index a2995db..9bcc3f7 100644 --- a/readme.txt +++ b/readme.txt @@ -3,6 +3,8 @@ Contributors: matt, wordpressdotorg Stable tag: 1.7.2 Tested up to: 6.1 Requires at least: 4.6 +License: GPLv2 or later +License URI: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html This is not just a plugin, it symbolizes the hope and enthusiasm of an entire generation summed up in two words sung most famously by Louis Armstrong. From f24ccfc91462687ca00d22f3d8e59bab405391f0 Mon Sep 17 00:00:00 2001 From: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> Date: Thu, 24 Oct 2024 11:32:51 -0700 Subject: [PATCH 5/6] Bump tested up to version --- readme.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.txt b/readme.txt index 9bcc3f7..0369207 100644 --- a/readme.txt +++ b/readme.txt @@ -1,7 +1,7 @@ === Hello Dolly === Contributors: matt, wordpressdotorg Stable tag: 1.7.2 -Tested up to: 6.1 +Tested up to: 6.6 Requires at least: 4.6 License: GPLv2 or later License URI: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html From 50600cb1f5369d36c2be70ee2f8245733a24492d Mon Sep 17 00:00:00 2001 From: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> Date: Thu, 24 Oct 2024 11:56:38 -0700 Subject: [PATCH 6/6] Bump stable tag to match SVN See https://plugins.svn.wordpress.org/hello-dolly/tags/1.7.3/readme.txt. --- hello.php | 4 ++-- readme.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hello.php b/hello.php index 927b22a..ba20e97 100644 --- a/hello.php +++ b/hello.php @@ -1,14 +1,14 @@ Hello, Dolly in the upper right of your admin screen on every page. Author: Matt Mullenweg -Version: 1.7.2 +Version: 1.7.3 Author URI: http://ma.tt/ License: GPLv2 or later License URI: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html diff --git a/readme.txt b/readme.txt index 0369207..61b158e 100644 --- a/readme.txt +++ b/readme.txt @@ -1,6 +1,6 @@ === Hello Dolly === Contributors: matt, wordpressdotorg -Stable tag: 1.7.2 +Stable tag: 1.7.3 Tested up to: 6.6 Requires at least: 4.6 License: GPLv2 or later