From 9ce86c2fa5a795d517fc594f7d076edf6f3c35ed Mon Sep 17 00:00:00 2001 From: Bernie Reiter Date: Mon, 20 Oct 2025 11:00:28 +0200 Subject: [PATCH 1/3] Pattern Overrides: Add support for Image caption attribute --- packages/patterns/src/constants.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/patterns/src/constants.js b/packages/patterns/src/constants.js index 99563a1a16787f..9f35b719949c42 100644 --- a/packages/patterns/src/constants.js +++ b/packages/patterns/src/constants.js @@ -20,7 +20,7 @@ export const PARTIAL_SYNCING_SUPPORTED_BLOCKS = { 'core/paragraph': [ 'content' ], 'core/heading': [ 'content' ], 'core/button': [ 'text', 'url', 'linkTarget', 'rel' ], - 'core/image': [ 'id', 'url', 'title', 'alt' ], + 'core/image': [ 'id', 'url', 'title', 'alt', 'caption' ], }; export const PATTERN_OVERRIDES_BINDING_SOURCE = 'core/pattern-overrides'; From a2854928ad47e1ab3ab4d5d95a2fbc75954bd77c Mon Sep 17 00:00:00 2001 From: Bernie Reiter Date: Mon, 20 Oct 2025 18:05:08 +0200 Subject: [PATCH 2/3] Update overrides control message --- packages/patterns/src/components/pattern-overrides-controls.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/patterns/src/components/pattern-overrides-controls.js b/packages/patterns/src/components/pattern-overrides-controls.js index 5207348c7bd7c6..57f39c5a9e4531 100644 --- a/packages/patterns/src/components/pattern-overrides-controls.js +++ b/packages/patterns/src/components/pattern-overrides-controls.js @@ -67,7 +67,7 @@ function PatternOverridesControls( { const helpText = ! hasOverrides && hasUnsupportedImageAttributes ? __( - `Overrides currently don't support image captions or links. Remove the caption or link first before enabling overrides.` + `Overrides currently don't support image links. Remove the link first before enabling overrides.` ) : __( 'Allow changes to this block throughout instances of this pattern.' From dc7851d470ebb11c3ae74e03eb87e59c8b728aba Mon Sep 17 00:00:00 2001 From: Bernie Reiter Date: Mon, 20 Oct 2025 18:11:18 +0200 Subject: [PATCH 3/3] Remove check for caption attribute --- packages/patterns/src/components/pattern-overrides-controls.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/patterns/src/components/pattern-overrides-controls.js b/packages/patterns/src/components/pattern-overrides-controls.js index 57f39c5a9e4531..9ad905b8bd9724 100644 --- a/packages/patterns/src/components/pattern-overrides-controls.js +++ b/packages/patterns/src/components/pattern-overrides-controls.js @@ -61,8 +61,7 @@ function PatternOverridesControls( { } const hasUnsupportedImageAttributes = - blockName === 'core/image' && - ( !! attributes.caption?.length || !! attributes.href?.length ); + blockName === 'core/image' && !! attributes.href?.length; const helpText = ! hasOverrides && hasUnsupportedImageAttributes