-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Manual cherry pick of #62768 to wp/6.6 #62905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,7 @@ const { | |
| ExperimentalBlockEditorProvider, | ||
| GlobalStylesContext, | ||
| useGlobalStylesOutputWithConfig, | ||
| __unstableBlockStyleVariationOverridesWithConfig, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a bit of discussion around it. To answer the "why", to advertise without ambiguity that, despite being private, it's unstable. Similar to how private block editor functions have the I don't think it does any harm, but could easily be communicated in comments. I can rename it |
||
| } = unlock( blockEditorPrivateApis ); | ||
| const { mergeBaseAndUserConfigs } = unlock( editorPrivateApis ); | ||
|
|
||
|
|
@@ -74,7 +75,6 @@ function Revisions( { userConfig, blocks } ) { | |
| name="revisions" | ||
| tabIndex={ 0 } | ||
| > | ||
| <EditorStyles styles={ editorStyles } /> | ||
| <style> | ||
| { | ||
| // Forming a "block formatting context" to prevent margin collapsing. | ||
|
|
@@ -88,6 +88,14 @@ function Revisions( { userConfig, blocks } ) { | |
| settings={ settings } | ||
| > | ||
| <BlockList renderAppender={ false } /> | ||
| { /* | ||
| * Styles are printed inside the block editor provider, | ||
| * so they can access any registered style overrides. | ||
| */ } | ||
| <EditorStyles styles={ editorStyles } /> | ||
| <__unstableBlockStyleVariationOverridesWithConfig | ||
| config={ mergedConfig } | ||
| /> | ||
| </ExperimentalBlockEditorProvider> | ||
| </Disabled> | ||
| </Iframe> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.