From c971d7dd99848b757c90e7d166dd7539de70b198 Mon Sep 17 00:00:00 2001 From: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Date: Wed, 10 Nov 2021 12:33:21 +1000 Subject: [PATCH 1/2] Make jsdoc and unstableWidth prop use consistent for letter spacing control --- .../src/components/letter-spacing-control/index.js | 10 +++++----- packages/block-editor/src/hooks/letter-spacing.js | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/block-editor/src/components/letter-spacing-control/index.js b/packages/block-editor/src/components/letter-spacing-control/index.js index 0c44196673f20c..7a818fb087634b 100644 --- a/packages/block-editor/src/components/letter-spacing-control/index.js +++ b/packages/block-editor/src/components/letter-spacing-control/index.js @@ -15,12 +15,12 @@ import useSetting from '../../components/use-setting'; /** * Control for letter-spacing. * - * @param {Object} props Component props. - * @param {string} props.value Currently selected letter-spacing. - * @param {Function} props.onChange Handles change in letter-spacing selection. - * @param {boolean} props.__unstableInputWidth Input width to pass through to inner UnitControl. + * @param {Object} props Component props. + * @param {string} props.value Currently selected letter-spacing. + * @param {Function} props.onChange Handles change in letter-spacing selection. + * @param {string|number|null} props.__unstableInputWidth Input width to pass through to inner UnitControl. * - * @return {WPElement} Letter-spacing control. + * @return {WPElement} Letter-spacing control. */ export default function LetterSpacingControl( { value, diff --git a/packages/block-editor/src/hooks/letter-spacing.js b/packages/block-editor/src/hooks/letter-spacing.js index 7aa76307d6dd4b..0009ae0f4aba55 100644 --- a/packages/block-editor/src/hooks/letter-spacing.js +++ b/packages/block-editor/src/hooks/letter-spacing.js @@ -45,7 +45,7 @@ export function LetterSpacingEdit( props ) { ); } From 85635f5a6d97ad467b73f1b529157265dd261ae3 Mon Sep 17 00:00:00 2001 From: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Date: Fri, 12 Nov 2021 12:47:10 +1000 Subject: [PATCH 2/2] Improve approach --- .../src/components/letter-spacing-control/index.js | 8 ++++---- packages/block-editor/src/hooks/letter-spacing.js | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/block-editor/src/components/letter-spacing-control/index.js b/packages/block-editor/src/components/letter-spacing-control/index.js index 7a818fb087634b..591b5593c62fc5 100644 --- a/packages/block-editor/src/components/letter-spacing-control/index.js +++ b/packages/block-editor/src/components/letter-spacing-control/index.js @@ -15,10 +15,10 @@ import useSetting from '../../components/use-setting'; /** * Control for letter-spacing. * - * @param {Object} props Component props. - * @param {string} props.value Currently selected letter-spacing. - * @param {Function} props.onChange Handles change in letter-spacing selection. - * @param {string|number|null} props.__unstableInputWidth Input width to pass through to inner UnitControl. + * @param {Object} props Component props. + * @param {string} props.value Currently selected letter-spacing. + * @param {Function} props.onChange Handles change in letter-spacing selection. + * @param {string|number|undefined} props.__unstableInputWidth Input width to pass through to inner UnitControl. Should be a valid CSS value. * * @return {WPElement} Letter-spacing control. */ diff --git a/packages/block-editor/src/hooks/letter-spacing.js b/packages/block-editor/src/hooks/letter-spacing.js index 0009ae0f4aba55..3dc0d82b7b9a7a 100644 --- a/packages/block-editor/src/hooks/letter-spacing.js +++ b/packages/block-editor/src/hooks/letter-spacing.js @@ -45,7 +45,7 @@ export function LetterSpacingEdit( props ) { ); }