-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Patterns Explorer: Improve pagination layout when 'Show button text labels' preference is enabled #61754
Copy link
Copy link
Closed
Labels
[Feature] PatternsA collection of blocks that can be synced (previously reusable blocks) or unsyncedA collection of blocks that can be synced (previously reusable blocks) or unsynced[Feature] Show button text labelsA preference in the Post and Site Editor that makes buttons show text instead of iconsA preference in the Post and Site Editor that makes buttons show text instead of icons[Package] Block editor/packages/block-editor/packages/block-editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Metadata
Metadata
Assignees
Labels
[Feature] PatternsA collection of blocks that can be synced (previously reusable blocks) or unsyncedA collection of blocks that can be synced (previously reusable blocks) or unsynced[Feature] Show button text labelsA preference in the Post and Site Editor that makes buttons show text instead of iconsA preference in the Post and Site Editor that makes buttons show text instead of icons[Package] Block editor/packages/block-editor/packages/block-editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Type
Fields
Give feedbackNo fields configured for issues without a type.
Description
When the preference 'Show button text labels' is eneabled, the Patterns Explorer pagination items are stacked vertically because of a CSS
flex-direction: column;. Screenshot:Not sure this is ideal.
I'm not sure what the reasoning behind this layout was. It appears to be new CSS introduced in #53835 and seems intentional.
While on small screns laying out these items vertically would make sense, on large screens there is space to lay out them horizontally, no differently from their layout when 'Show button text labels` is disabled. Screenshot:
I'd like to propose to stack them vertically only udner a certain viewport width.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes