As evidenced by this PR
the PHP side of the duotone block supports is potentially brittle and prone to regressions.
We should break gutenberg_render_duotone_support into smaller units and add tests for the results to provide more confidence. This should also make the code easier to reason about.
@draganescu @scruffian Thanks for catching custom color breakage. I've reinstated some code I accidentally removed during a refactor. Points to this code being brittle and requiring tests.
Originally posted by @getdave in #48318 (comment)
As evidenced by this PR
the PHP side of the duotone block supports is potentially brittle and prone to regressions.
We should break
gutenberg_render_duotone_supportinto smaller units and add tests for the results to provide more confidence. This should also make the code easier to reason about.@draganescu @scruffian Thanks for catching custom color breakage. I've reinstated some code I accidentally removed during a refactor. Points to this code being brittle and requiring tests.
Originally posted by @getdave in #48318 (comment)