You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The `diff 4 → 8` bump from `syncpack fix` causes 51 unit tests to fail
in `block-diff.js` due to two unrelated upstream changes:
1. v6's "deletions before insertions" tie-breaker selects a different
(but equally-valid) LCS for inputs where the whitespace block is
pickable as a match. `pairSimilarBlocks` then sees two removed and
two added paragraphs (instead of one of each) and incorrectly pairs
dissimilar blocks via similarity matching, producing confusing
inline diffs in the post revisions UI.
2. v6's `diffWords` no longer treats whitespace as a token, so adjacent
word changes coalesce into one removed/added pair instead of being
reported per-word.
Both are real user-visible regressions in the revisions feature, not
just snapshot drift, and the proper fix lives in `block-diff.js` (a
custom LCS that prefers content-bearing matches, plus
`diffWordsWithSpace` for the inline diff). That work is tracked in
`issue-upgrade-diff-v8.md` for a dedicated trunk PR with the right
reviewers.
For now, update the four affected test cases on this branch to assert
the v8 output so the syncpack alignment validation can proceed end to
end. Each updated assertion carries a `TODO(diff v8 upgrade)` marker
pointing at the tracking issue. When the dedicated `diff` upgrade PR
lands on trunk with the consumer-side fix, the alignment PR (#77954)
will rebase and the markers/asserts here should be reverted as part of
that rebase — restoring the original v4-equivalent expectations.
0 commit comments