New Poetry variations and header font fixing (#199)#210
Conversation
Preview changesI've detected changes to the following themes in this PR: Poetry, Term. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
Can we get a different name for the "My typo" variation? These look nice. The variations are highlighting some issues that the theme has with padding and the little feather icon, but we can handle those separately |
| <div class="wp-block-group"><!-- wp:paragraph {"style":{"typography":{"lineHeight":"0.8"}},"fontSize":"xx-large","fontFamily":"rozha-one"} --> | ||
| <p class="has-rozha-one-font-family has-xx-large-font-size" style="line-height:0.8">Food <br>for thoughts</p> | ||
| <div class="wp-block-group"><!-- wp:paragraph {"style":{"typography":{"lineHeight":"0.8"}},"fontSize":"xx-large","fontFamily":"heading"} --> | ||
| <h2 class="has-heading-font-family has-xx-large-font-size" style="line-height:0.8">Food <br>for thoughts</h2> |
There was a problem hiding this comment.
we made this change but then we don't assign a "heading" font family in the .json files. The class has-heading-font-family is not resolving to anything so this change is not really doing anything. We could remove the class altogether and just let the theme default to whatever the theme.json sets for all headings. That is probably the best case for this particular theme, but that means that no templates/patterns can select specific font families and expect the theme to be able to adapt when we change to a different variation that doesn't have that specific font family.
|
@ironicmoka, could you please add the font license? Also, could you please update as suggested changes as above? |
3 participants
New variations for Poetry theme and a small fix to the header font handling