Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/wanieldeiss/src/app/app.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
id="index-section"
class="snap-start w-screen h-screen flex items-center justify-center"
/>
<wd-about
id="about-section"
class="snap-start w-screen h-screen flex items-center justify-center"
/>
<wd-cv
id="cv-section"
class="snap-start w-screen h-screen flex items-center justify-center"
Expand Down
4 changes: 2 additions & 2 deletions apps/wanieldeiss/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
PageWrapperComponent,
SocialIconBarComponent,
} from './components';
import { IndexPage, CvPage } from './pages';
import { IndexPage, CvPage, AboutPage } from './pages';
import { HttpClientModule } from '@angular/common/http';
import { TypingDirective } from './directives/typing.directive';
import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';
Expand All @@ -23,7 +23,7 @@ const COMPONENTS = [
PageWrapperComponent,
SocialIconBarComponent,
];
const PAGES = [IndexPage, CvPage];
const PAGES = [AboutPage, IndexPage, CvPage];

@NgModule({
declarations: [AppComponent, ...COMPONENTS, ...PAGES, TypingDirective],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,23 @@
<nav>
<ul class="flex">
<li class="mr-4">
<span (click)="click('index-section')" class="hover:cursor-pointer">

Check warning on line 24 in apps/wanieldeiss/src/app/components/header/header.component.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add a 'onKeyPress|onKeyDown|onKeyUp' attribute to this <span> tag.

See more on https://sonarcloud.io/project/issues?id=WanielDeiss_wanieldeiss.com&issues=AZ2XGEvQ2qvbif5B96bq&open=AZ2XGEvQ2qvbif5B96bq&pullRequest=25
Home
</span>
</li>

<li class="mr-4">
<span (click)="click('about-section')" class="hover:cursor-pointer">

Check warning on line 30 in apps/wanieldeiss/src/app/components/header/header.component.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add a 'onKeyPress|onKeyDown|onKeyUp' attribute to this <span> tag.

See more on https://sonarcloud.io/project/issues?id=WanielDeiss_wanieldeiss.com&issues=AZ2XGEvQ2qvbif5B96br&open=AZ2XGEvQ2qvbif5B96br&pullRequest=25
About
</span>
</li>
<li class="mr-4">
<span (click)="click('cv-section')" class="hover:cursor-pointer">

Check warning on line 35 in apps/wanieldeiss/src/app/components/header/header.component.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add a 'onKeyPress|onKeyDown|onKeyUp' attribute to this <span> tag.

See more on https://sonarcloud.io/project/issues?id=WanielDeiss_wanieldeiss.com&issues=AZ2XGEvQ2qvbif5B96bs&open=AZ2XGEvQ2qvbif5B96bs&pullRequest=25
CV
</span>
</li>
<li class="w-6 h-6">
<span (click)="clickToggleDarkMode()" class="hover:cursor-pointer">

Check warning on line 40 in apps/wanieldeiss/src/app/components/header/header.component.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add a 'onKeyPress|onKeyDown|onKeyUp' attribute to this <span> tag.

See more on https://sonarcloud.io/project/issues?id=WanielDeiss_wanieldeiss.com&issues=AZ2XGEvQ2qvbif5B96bt&open=AZ2XGEvQ2qvbif5B96bt&pullRequest=25
<svg
fill="none"
stroke="currentColor"
Expand Down
3 changes: 3 additions & 0 deletions apps/wanieldeiss/src/app/pages/about/about.page.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<wd-page-wrapper>
<div class="h-full overflow-y-auto">ABOUT</div>
</wd-page-wrapper>
Empty file.
22 changes: 22 additions & 0 deletions apps/wanieldeiss/src/app/pages/about/about.page.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';

import { AboutPage } from './about.page';

describe('IndexComponent', () => {
let component: AboutPage;
let fixture: ComponentFixture<AboutPage>;

beforeEach(async () => {
await TestBed.configureTestingModule({
declarations: [AboutPage],
}).compileComponents();

fixture = TestBed.createComponent(AboutPage);
component = fixture.componentInstance;
fixture.detectChanges();
});

it('should create', () => {
expect(component).toBeTruthy();
});
});
8 changes: 8 additions & 0 deletions apps/wanieldeiss/src/app/pages/about/about.page.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { Component } from '@angular/core';

@Component({
selector: 'wd-about',
templateUrl: './about.page.html',
styleUrls: ['./about.page.scss'],
})
export class AboutPage {}
1 change: 1 addition & 0 deletions apps/wanieldeiss/src/app/pages/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
export * from './about/about.page';
export * from './cv/cv.page';
export * from './index/index.page';