From 0dfa2d3fd712ea94fd9b6b4c40ee7b944c3a9db5 Mon Sep 17 00:00:00 2001 From: Ethirix Date: Thu, 21 May 2026 20:22:36 +0100 Subject: [PATCH 1/2] Added explicit permissions to xplat workflow --- .github/workflows/pr-xplat-build-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr-xplat-build-test.yml b/.github/workflows/pr-xplat-build-test.yml index 6fdabcf..27dc508 100644 --- a/.github/workflows/pr-xplat-build-test.yml +++ b/.github/workflows/pr-xplat-build-test.yml @@ -63,6 +63,7 @@ jobs: verify-compilation-task: if: always() + permissions: {} runs-on: ubuntu-latest needs: [check-files, build] steps: From 4e6638a27946dcf5cd916703020054bf844a064f Mon Sep 17 00:00:00 2001 From: Ethirix Date: Thu, 21 May 2026 21:06:03 +0100 Subject: [PATCH 2/2] Fixed incorrect action logic for skipping compilation --- .github/workflows/pr-xplat-build-test.yml | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/pr-xplat-build-test.yml b/.github/workflows/pr-xplat-build-test.yml index 27dc508..b60c5b3 100644 --- a/.github/workflows/pr-xplat-build-test.yml +++ b/.github/workflows/pr-xplat-build-test.yml @@ -2,24 +2,20 @@ on: pull_request: branches: [ 'master' ] - paths: - - 'libvlmath/**' - - 'toolchains/**' - - 'CMake**.**' jobs: check-files: runs-on: ubuntu-latest permissions: contents: read - outputs: + outputs: files_found: ${{ steps.found-files.outputs.files_found }} steps: - uses: actions/checkout@v4 - id: changed-files uses: tj-actions/changed-files@v47.0.1 - with: + with: base_sha: ${{ github.base_ref }} files: | libvlmath/** @@ -27,15 +23,15 @@ jobs: CMake**.** - shell: bash id: found-files - run: echo "files_found=${{ steps.changed-files.outputs.any_modified }}" >> $GITHUB_OUTPUT + run: echo files_found=${{ steps.changed-files.outputs.any_modified }} >> $GITHUB_OUTPUT build: runs-on: ubuntu-latest needs: check-files - if: ${{ needs.check-files.outputs.files_found }} + if: needs.check-files.outputs.files_found == 'true' permissions: contents: read - + strategy: fail-fast: true matrix: @@ -50,7 +46,7 @@ jobs: compiler: gcc - target: linux compiler: mingw64 - + steps: - uses: VolcanusLucis/.github/.github/actions/build-cmake-project-presets@master with: