Skip to content

[NeurIPS Rebuttal] Codebase Polish, API Simplification, and GNN Bug Fix #22

Description

@Jiaqing-ASU

Context:
Addressing Reviewer z8Q2's comments regarding the codebase and open-source standards for the NeurIPS rebuttal.

Action Items:

  • Fix GNN 2-node bug (Reviewer z8Q2 - Q17): Fix the aggressive default noise-filtering threshold that collapsed the smaller persistence bars, ensuring the un-filtered topological structure is accurately plotted.
  • API Design Update (Reviewer z8Q2 - Q18): Simplify the compute() API so users only need to provide a standard loss criterion (removing the confusion around scalar_function).
  • Documentation & Tests: Ensure comprehensive docstrings, unit tests, and explanatory markdown texts are added to the example notebooks to meet open-source standards.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions