fix: serialize ESM loader TypeScript errors#2172
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
a2aa830 to
49ea0c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2111.
What changed
TSErrorinstances crossing the ESM loader worker boundary into a serializableErrorcopy.tsconfig.jsonand assert the ESM loader prints the real TypeScript diagnostic instead of[Object: null prototype].Verification
YARN_ENABLE_GLOBAL_CACHE=false YARN_CACHE_FOLDER=/tmp/ts-node-2111-yarn-cache YARN_NM_MODE=classic yarn test-spec ./dist/test/esm-loader.spec.js --match '*reports invalid tsconfig diagnostics from the ESM loader*'YARN_ENABLE_GLOBAL_CACHE=false YARN_CACHE_FOLDER=/tmp/ts-node-2111-yarn-cache YARN_NM_MODE=classic yarn build-tscYARN_ENABLE_GLOBAL_CACHE=false YARN_CACHE_FOLDER=/tmp/ts-node-2111-yarn-cache YARN_NM_MODE=classic yarn lintYARN_ENABLE_GLOBAL_CACHE=false YARN_CACHE_FOLDER=/tmp/ts-node-2111-yarn-cache YARN_NM_MODE=classic yarn test-spec ./dist/test/esm-loader.spec.js --match '*reports invalid tsconfig diagnostics from the ESM loader*'YARN_ENABLE_GLOBAL_CACHE=false YARN_CACHE_FOLDER=/tmp/ts-node-2111-yarn-cache YARN_NM_MODE=classic yarn test-spec ./dist/test/esm-loader.spec.js --match '*should throw type errors without transpile-only enabled*'YARN_ENABLE_GLOBAL_CACHE=false YARN_CACHE_FOLDER=/tmp/ts-node-2111-yarn-cache YARN_NM_MODE=classic yarn test-spec ./dist/test/diagnostics.spec.jsgit diff --checkI also tried the full
esm-loader.spec.jsfile locally, but the Node 24.15.0 runtime trips several existing expectations unrelated to this change, including source-map line expectations, import-assertion syntax, and deprecation-warning stderr assertions.