From a6a4eb731990b57b33bbe3449db73b5998215ea6 Mon Sep 17 00:00:00 2001 From: Tunatroll Date: Sat, 7 Mar 2026 09:30:25 -0700 Subject: [PATCH 1/2] Add grand-flip-out plugin with IP warning Added grand-flip-out plugin with repository details and warning. --- plugins/grand-flip-out | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 plugins/grand-flip-out diff --git a/plugins/grand-flip-out b/plugins/grand-flip-out new file mode 100644 index 000000000000..d68fcc708b2a --- /dev/null +++ b/plugins/grand-flip-out @@ -0,0 +1,3 @@ +repository=https://github.com/Tunatroll/grand-flip-out.git +commit=1d2649de4cb8cdac32a771b6e6fcb9396e32fdc1 +warning=This plugin submits your IP address to a 3rd-party server not controlled or verified by RuneLite developers. From e17bf74c7401095c7208a9f5cbdcd79d2c00f6ea Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 19 May 2026 05:54:54 +0000 Subject: [PATCH 2/2] Add descriptor commit validation coverage Co-authored-by: Tunatroll --- .../net/runelite/pluginhub/packager/Plugin.java | 2 +- .../runelite/pluginhub/packager/PluginTest.java | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/package/package/src/main/java/net/runelite/pluginhub/packager/Plugin.java b/package/package/src/main/java/net/runelite/pluginhub/packager/Plugin.java index 44e629910f83..1cfd10172658 100644 --- a/package/package/src/main/java/net/runelite/pluginhub/packager/Plugin.java +++ b/package/package/src/main/java/net/runelite/pluginhub/packager/Plugin.java @@ -248,7 +248,7 @@ public Plugin(File pluginCommitDescriptor) throws IOException, DisabledPluginExc } commit = (String) cd.remove("commit"); - if (!COMMIT_TEST.matcher(commit).matches()) + if (commit == null || !COMMIT_TEST.matcher(commit).matches()) { throw PluginBuildException.of(internalName, "commit must be a full 40 character sha1sum") .withFileLine(pluginCommitDescriptor, "commit=" + commit); diff --git a/package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.java b/package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.java index 3aa33c51ff22..27fea25e7a0b 100644 --- a/package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.java +++ b/package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.java @@ -53,6 +53,23 @@ public void testInternalNameChecks() throws IOException, DisabledPluginException } } + @Test + public void testCommitIsRequired() throws DisabledPluginException, IOException + { + try + { + newPlugin("test", "" + + "repository=https://github.com/runelite/example-plugin.git\n"); + Assert.fail(); + } + catch (PluginBuildException e) + { + log.info("ok: ", e); + assertContains(e.getMessage(), "commit must be a full 40 character sha1sum"); + assertContains(e.getHelpText(), "commit=null"); + } + } + @Test public void testCommitMustBeComplete() throws DisabledPluginException, IOException {