Skip to content

Calculation of Rates in GetOorU function #3

Description

@davidjtgrant

I think we are missing "brackets" in calculation of the two rates.

performanceRate = sumOfSevenDayAverage - sumOfPurchasePrice / sumOfPurchasePrice

I believe it should be:
performanceRate = (sumOfSevenDayAverage - sumOfPurchasePrice) / sumOfPurchasePrice

and:

historicalEthRate = currentEthPrice - ethPriceAtTimeOfFirstMint / ethPriceAtTimeOfFirstMint

I believe it should be:
historicalEthRate = (currentEthPrice - ethPriceAtTimeOfFirstMint) / ethPriceAtTimeOfFirstMint

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions