From ce39bb77d97077f2f0664e21dc02dcc75a67c82a Mon Sep 17 00:00:00 2001 From: Pedro Alvito Date: Tue, 19 Feb 2019 20:08:03 +0100 Subject: [PATCH 1/2] Removed deprecated V8 methods warnings for node 10/11 --- src/binding.cc | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/binding.cc b/src/binding.cc index 7075be1..8a5996e 100644 --- a/src/binding.cc +++ b/src/binding.cc @@ -219,7 +219,7 @@ NAN_METHOD(WriteObject) { Nan::Persistent* pptr = reinterpret_cast*>(ptr); Local val = info[2].As(); - bool persistent = info[3]->BooleanValue(); + bool persistent = Nan::To(info[3]).FromJust(); if (persistent) { (*pptr).Reset(val); } else { @@ -250,7 +250,8 @@ NAN_METHOD(ReadPointer) { int64_t offset = GetInt64(info[1]); char *ptr = Buffer::Data(buf.As()) + offset; - size_t size = info[2]->Uint32Value(); + + size_t size = Nan::To(info[2]).FromJust();; if (ptr == NULL) { return Nan::ThrowError("readPointer: Cannot read from NULL pointer"); @@ -357,8 +358,7 @@ NAN_METHOD(WriteInt64) { } else if (in->IsString()) { char *endptr, *str; int base = 0; - String::Utf8Value _str(in); - str = *_str; + str = *Nan::Utf8String(in); errno = 0; /* To distinguish success/failure after call */ val = strtoll(str, &endptr, base); @@ -444,8 +444,7 @@ NAN_METHOD(WriteUInt64) { } else if (in->IsString()) { char *endptr, *str; int base = 0; - String::Utf8Value _str(in); - str = *_str; + str = *Nan::Utf8String(in); errno = 0; /* To distinguish success/failure after call */ val = strtoull(str, &endptr, base); @@ -518,7 +517,7 @@ NAN_METHOD(ReinterpretBuffer) { return Nan::ThrowError("reinterpret: Cannot reinterpret from NULL pointer"); } - size_t size = info[1]->Uint32Value(); + size_t size = Nan::To(info[1]).FromJust();; info.GetReturnValue().Set(WrapPointer(ptr, size)); } @@ -547,7 +546,7 @@ NAN_METHOD(ReinterpretBufferUntilZeros) { return Nan::ThrowError("reinterpretUntilZeros: Cannot reinterpret from NULL pointer"); } - uint32_t numZeros = info[1]->Uint32Value(); + uint32_t numZeros = Nan::To(info[1]).FromJust(); uint32_t i = 0; size_t size = 0; bool end = false; @@ -642,8 +641,8 @@ NAN_MODULE_INIT(init) { // exports target->Set(Nan::New("sizeof").ToLocalChecked(), smap); target->Set(Nan::New("alignof").ToLocalChecked(), amap); - Nan::ForceSet(target, Nan::New("endianness").ToLocalChecked(), Nan::New(CheckEndianness()).ToLocalChecked(), static_cast(ReadOnly|DontDelete)); - Nan::ForceSet(target, Nan::New("NULL").ToLocalChecked(), WrapNullPointer(), static_cast(ReadOnly|DontDelete)); + Nan::DefineOwnProperty(target, Nan::New("endianness").ToLocalChecked(), Nan::New(CheckEndianness()).ToLocalChecked(), static_cast(ReadOnly|DontDelete)); + Nan::DefineOwnProperty(target, Nan::New("NULL").ToLocalChecked(), WrapNullPointer(), static_cast(ReadOnly|DontDelete)); Nan::SetMethod(target, "address", Address); Nan::SetMethod(target, "hexAddress", HexAddress); Nan::SetMethod(target, "isNull", IsNull); From de2c242f72a1c4852f2baa6b4398a43a494f1480 Mon Sep 17 00:00:00 2001 From: Pedro Alvito Date: Tue, 19 Feb 2019 22:43:12 +0100 Subject: [PATCH 2/2] Fixed version of mocha --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 503e10b..345c3bc 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "highlight.js": "1", "jade": "1", "marked": "0.5.2", - "mocha": "*", + "mocha": "5.0.0", "weak": "1" } }