Improve ParsingException by including cursor location when possible#166
Draft
burdoto wants to merge 3 commits into
Draft
Improve ParsingException by including cursor location when possible#166burdoto wants to merge 3 commits into
burdoto wants to merge 3 commits into
Conversation
some new parameters were introduced on existing methods, but only on private or internal utility methods; so that should be fine
not sure if this very niche case should be handled at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105, Closes #165
This PR introduces the
Cursorinterface that has methods to gather information about cursor information.If a
Cursoris passed to aParsingException, the exception message is being appended with line and position information obtained from theCursorat the moment when the exception is thrown.Some internal things; such as private helper methods and some (supposedly internal) utility methods from
com.electronwill.nightconfig.core.io.Utilshad a new,@Nullableparameter added in order to pass aCursor.Documentation for added code is still missing.
Hocon tests are failing for a reason outside of this PR.
Needs in-depth testing and new unit tests.