Footer style margin right not working

[beucismis]

Footer style margin right not working.

textual version: 8.2.8

The bug

from textual.app import App, ComposeResult
from textual.widgets import Footer


class FooterTest(App):
    def compose(self) -> ComposeResult:
        self.footer = Footer()
        yield self.footer

    def on_mount(self) -> None:
        self.footer.styles.margin = 5


if __name__ == "__main__":
    app = FooterTest()
    app.run()

[github-actions]

We found the following entries in the FAQ which you may find helpful:

• Why do some key combinations never make it to my app?
• How can I set a translucent app background?
• Why doesn't Textual support ANSI themes?

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This project is developed and maintained by Will McGugan. Consider sponsoring Will's work on this project (and others).

This is an automated reply, generated by FAQtory

[ninix07]

Hello @willmcgugan, I would like to take up this issue as I have already implemented and verified the fix on my end.

• Cause: Footer inherits width: 1fr from ScrollableContainer, which resolves docked width to the full screen size without subtracting margins, causing the right margin to clip off-screen.
• Fix: Adding width: 100%; to the Footer widget's DEFAULT_CSS overrides the inherited 1fr and resolves its width relative to the screen size minus margins, respecting the margins correctly.

Happy to open a PR once you sign off on this approach.

[ninix07]

Hi! I've submitted a PR addressing this issue: #6618 . I'd appreciate any feedback.