You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the MAX_EDICT_BITS change is fine, but caching game.SinglePlayer is unecessary given that its not called every tick/frame. I've explained my reasons for that on #303
I think the MAX_EDICT_BITS change is fine, but caching game.SinglePlayer is unecessary given that its not called every tick/frame. I've explained my reasons for that on #303
Indeed, the game.SinglePlayer parameter isn't necessary in some cases. Actually, I based it on the fact that the user could spam the toolgun button using a macro or auto-click. It's very neat, hence this pull request only concerns micro-optimization, but it's necessary to "save" a few nanoseconds.
Besides, even with the Material tool that you can spam, game.SinglePlayer is nothing compared to the other dupe/list stuff that it checks.
That does not mean those other things have to be micro-optimized too, it just means that the toolgun is not slow enough to need that, and once again I come back to #303:
How likely is a section of code to be running constantly?
Besides, even with the Material tool that you can spam, game.SinglePlayer is nothing compared to the other dupe/list stuff that it checks.
That does not mean those other things have to be micro-optimized too, it just means that the toolgun is not slow enough to need that, and once again I come back to #303:
How likely is a section of code to be running constantly?
Okay, I understand. I'll modify my PR to include only MAX_EDICT_BITS and the WriteTable from Glide.
I forgot that data from Glide.lastStreamPresetData is a string, not a table, so it's causing an error when given to Glide.WriteTable. I'm going to fix it in a minute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.