From 7f5787c249a3705f45a959996724ccdd028c1a10 Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Tue, 13 Jan 2026 11:27:15 -0400 Subject: [PATCH 1/3] Fix field type name in readme --- changelog.txt | 2 +- readme.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changelog.txt b/changelog.txt index c13bbb3f1c..3334db44d0 100644 --- a/changelog.txt +++ b/changelog.txt @@ -9,7 +9,7 @@ * Fix: Global custom CSS would incorrectly get added to the formidableforms.css more than once on some sites with multiple styles. * Fix: The style-specific custom CSS setting would incorrectly get output in the formidableforms.css file as CSS variable data. * Fix: The htaccess file included in this plugin is now automatically deleted when migrating to a new plugin version if a request to load CSS is blocked, fixing a conflict on some servers that are not configured to allow overwriting file permissions. -* Fix: A PHP warning would get logged when checking data for a rank field as spam. +* Fix: A PHP warning would get logged when checking data for a ranking field as spam. * Fix: Add-on category counts were not always correct. * Breaking: Many modern PHP functions are now being used including str_contains, str_starts_with, str_ends_with, array_key_last, and array_key_first. If you are using both a WordPress version older than 5.9, and a PHP version lower than 8.0, this will introduce fatal errors. Note that the minimum required WordPress version is already set to 6.3. * Breaking: The deprecated functions FrmFieldCaptcha::captcha_size, FrmFormsHelper::should_use_pro_for_ajax_submit, FrmFormsController::add_form_style_tab_options, and FrmFieldType::get_select_atributes have been removed. diff --git a/readme.txt b/readme.txt index 39aa602ebe..7d38de0b4e 100644 --- a/readme.txt +++ b/readme.txt @@ -382,7 +382,7 @@ See all [Formidable Zapier Integrations](https://zapier.com/apps/formidable/inte * Fix: Global custom CSS would incorrectly get added to the formidableforms.css more than once on some sites with multiple styles. * Fix: The style-specific custom CSS setting would incorrectly get output in the formidableforms.css file as CSS variable data. * Fix: The htaccess file included in this plugin is now automatically deleted when migrating to a new plugin version if a request to load CSS is blocked, fixing a conflict on some servers that are not configured to allow overwriting file permissions. -* Fix: A PHP warning would get logged when checking data for a rank field as spam. +* Fix: A PHP warning would get logged when checking data for a ranking field as spam. * Fix: Add-on category counts were not always correct. * Breaking: Many modern PHP functions are now being used including str_contains, str_starts_with, str_ends_with, array_key_last, and array_key_first. If you are using both a WordPress version older than 5.9, and a PHP version lower than 8.0, this will introduce fatal errors. Note that the minimum required WordPress version is already set to 6.3. * Breaking: The deprecated functions FrmFieldCaptcha::captcha_size, FrmFormsHelper::should_use_pro_for_ajax_submit, FrmFormsController::add_form_style_tab_options, and FrmFieldType::get_select_atributes have been removed. From 6e8bbe5b281995b56b5a6e4c1726d1d34a419ba1 Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Tue, 13 Jan 2026 11:29:43 -0400 Subject: [PATCH 2/3] Ignore new rector rule for now --- rector.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rector.php b/rector.php index c5f964dd69..054d6a5ae8 100644 --- a/rector.php +++ b/rector.php @@ -62,6 +62,7 @@ use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector; // TypeDeclarationDocblocks +use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForDimFetchArrayFromAssignsRector; use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromAssignsParamToParamReferenceRector; use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector; use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockReturnArrayFromDirectArrayInstanceRector; @@ -208,5 +209,6 @@ AddParamArrayDocblockFromAssignsParamToParamReferenceRector::class, AddParamArrayDocblockFromDimFetchAccessRector::class, DocblockReturnArrayFromDirectArrayInstanceRector::class, + AddReturnDocblockForDimFetchArrayFromAssignsRector::class, ) ); From d0d07e787a96f9ab481821a4da320355df06de92 Mon Sep 17 00:00:00 2001 From: Mike Letellier Date: Tue, 13 Jan 2026 11:32:42 -0400 Subject: [PATCH 3/3] Ignore a couple new rector rules for now --- rector.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rector.php b/rector.php index 054d6a5ae8..38b8dcb6ad 100644 --- a/rector.php +++ b/rector.php @@ -47,6 +47,8 @@ use Rector\DeadCode\Rector\FunctionLike\RemoveDeadReturnRector; use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector; use Rector\DeadCode\Rector\StaticCall\RemoveParentCallWithoutParentRector; +use Rector\DeadCode\Rector\ClassMethod\RemoveVoidDocblockFromMagicMethodRector; +use Rector\DeadCode\Rector\Node\RemoveNonExistingVarAnnotationRector; // EarlyReturn use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector; @@ -184,6 +186,8 @@ RemoveUnusedForeachKeyRector::class, RemoveUnusedPrivateMethodParameterRector::class, RemoveUnusedPrivateMethodRector::class, + RemoveVoidDocblockFromMagicMethodRector::class, + RemoveNonExistingVarAnnotationRector::class, // We never want to remove a valid param tag. Leave this exception. RemoveUselessParamTagRector::class, RemoveUselessReturnTagRector::class,