From 8f0d1cc73e5608724cf6a0374b37ee98a2e8af42 Mon Sep 17 00:00:00 2001
From: Mike Letellier <mike@crabcyb.org>
Date: Thu, 8 Jan 2026 13:51:12 -0400
Subject: [PATCH] Stop using ob functions to echo pro global settings

---
 classes/controllers/FrmSettingsController.php | 3 +--
 classes/views/frm-settings/general.php        | 8 +-------
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/classes/controllers/FrmSettingsController.php b/classes/controllers/FrmSettingsController.php
index c2a8249fa5..2b4ad476ab 100644
--- a/classes/controllers/FrmSettingsController.php
+++ b/classes/controllers/FrmSettingsController.php
@@ -286,11 +286,10 @@ public static function general_settings() {
 	 * Render the global currency selector if Pro is up to date.
 	 *
 	 * @param FrmSettings $frm_settings
-	 * @param string      $more_html
 	 *
 	 * @return void
 	 */
-	public static function maybe_render_currency_selector( $frm_settings, $more_html ) {
+	public static function maybe_render_currency_selector( $frm_settings ) {
 		if ( is_callable( 'FrmProSettingsController::add_currency_settings' ) ) {
 			FrmProSettingsController::add_currency_settings();
 			return;
diff --git a/classes/views/frm-settings/general.php b/classes/views/frm-settings/general.php
index 41d5a0527e..13d1a07aed 100644
--- a/classes/views/frm-settings/general.php
+++ b/classes/views/frm-settings/general.php
@@ -34,8 +34,6 @@
 </p>
 
 <?php
-ob_start();
-
 /**
  * Trigger an action so Pro can display additional General settings in the Other section.
  *
@@ -43,11 +41,7 @@
  */
 do_action( 'frm_settings_form', $frm_settings );
 
-$more_html = ob_get_clean();
-echo $more_html; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
-
-FrmSettingsController::maybe_render_currency_selector( $frm_settings, $more_html );
-unset( $more_html );
+FrmSettingsController::maybe_render_currency_selector( $frm_settings );
 ?>
 
 <div class="clear"></div>