logitnormal + unit_tests#59
Open
ujohn33 wants to merge 1 commit into
Open
Conversation
Author
|
@StatMixedML @nucflash please have a look once you find time |
|
Hi @ujohn33 , do we need unit tests specific to this distribution or is it covered by the tests that are run over all distributions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a Logit-Normal distribution to LightGBMLSS.
Summary
• Introduces a new LogitNormal distribution implemented as a transformed Normal with a sigmoid link
• Ensures correct support on (0, 1) via SigmoidTransform
• Integrates with the existing DistributionClass API
• Registers the distribution so it can be selected like other univariate continuous distributions
• Includes unit tests following the existing test structure
This PR is intentionally scoped to LogitNormal only, as discussed, and does not include unrelated refactors.