feat(judging): live results (remove RESULTS LOCKED)#189
Merged
Conversation
… scores The RESULTS tab no longer hides the standings behind a lock. The leaderboard now counts every saved score (not only finalized ballots), so it's live as judges score and an admin's own scores show up immediately. 'complete' (every submission scored) is informational and gates only PUBLISH; a LIVE banner shows coverage. Admins add scores via the SCORE tab as before; they now appear here. 438 server tests pass (leaderboard + sim journey updated for live behavior); client build + lint clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…g their ballot The ballot-submit lock blocked claiming new batches (409), so a judge who submitted one batch couldn't go through the rest. Since saved scores now count, remove that lock: claiming stays open after submit, and the batch overview is shown even when 'submitted'. Scores from later batches count on save.
…judges My earlier 'count all saved scores' change started counting wallet/admin sessions as a separate judge, so someone who is both an admin wallet and an email judge (e.g. sacha@) was double-counted in the leaderboard and breakdown. Count only email-judge scores (judgeEmail contains '@'); wallet sessions remain admin previews that never count. Applies to the leaderboard + the live overview.
The RESULTS leaderboard rows showed only title + scores. Add inline VIDEO (opens the review modal) and GIT links per row so they're accessible without expanding. Links stop row-click propagation so they don't toggle the breakdown.
…e-save) Expand a results row to get your own score inputs (pre-filled from your saved score) and a SAVE/RE-SAVE button, so a judge can score or revise a project straight from the final results without going back to the batch flow. Adds myScore per leaderboard row (the viewing judge's own score).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
RESULTS LOCKEDscreen so the admin can see all submissions + their scores anytime, and the admin's own scores show up.Changes
X/Y scored) until every submission has a score.complete) — can't publish with unscored submissions; the button is disabled with a tooltip until then.Safety
Read-path only (no scoring write-path changes).
ApiLeaderboardcollapsed to one always-rowsshape with acompleteflag. 438 server tests pass (leaderboard + sim journey updated); client build + lint clean.Note (product)
Published final results now include every saved score, not only submitted ballots. At publish time judging is done, so this is usually equivalent/better, but flagging the semantic change.