Skip to content

docs(pepper): document pepper-cooking lifecycle in caller example [DEV-243]#40

Merged
brodkin merged 1 commit into
mainfrom
ryan/dev-243-smoke-test-pepper-cooking
May 10, 2026
Merged

docs(pepper): document pepper-cooking lifecycle in caller example [DEV-243]#40
brodkin merged 1 commit into
mainfrom
ryan/dev-243-smoke-test-pepper-cooking

Conversation

@brodkin

@brodkin brodkin commented May 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a comment block to examples/caller-pepper-pr-review.yml describing the label states a PR moves through during a Pepper review (pepper-cooking during the run, exactly one outcome label after, unlabeled if the workflow fails before Pepper finishes).
  • Documentation only — no behavior change.

Why

This PR is the smoke test for DEV-237's lifecycle change. It validates two scenarios on production:

  1. Happy path — opening this PR triggers Pepper auto-review, which should apply pepper-cooking while running and swap to a single outcome label when done.
  2. Stale-label cleanup — after the first review concludes, stale outcome labels will be applied manually and @pepper review invoked again. The pre-clear step should strip ALL stale labels and the second review should end with exactly one outcome label.

Tracked in DEV-243.

Test plan

  • First Pepper review: PR carries pepper-cooking while in_progress; one outcome label after.
  • After Test 1 succeeds: manually gh pr edit --add-label "pepper-changes-requested" and gh pr edit --add-label "pepper-needs-review" to simulate stale labels alongside the existing outcome label.
  • Comment @pepper review to retrigger.
  • Second review: pre-clear strips all three stale labels, applies pepper-cooking, swaps to a single outcome label at the end.

…V-243]

Add a comment to the caller example explaining the label states a PR
goes through during a Pepper review (pepper-cooking while running,
exactly one outcome label after, unlabeled on workflow failure). Helps
adopters understand what they're seeing on PRs in their own repos.

This PR is also the smoke test for DEV-237's lifecycle change — see
DEV-243 for the validation plan.

Refs: DEV-243
@brodkin

brodkin commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

@pepper review

Retriggering after the fix in #41 landed and v1 now points at ad93722. This run should exercise the full pepper-cooking lifecycle: pepper-cooking applied during the run, swapped to a single outcome label at the end.

@pepper-pr-review pepper-pr-review Bot added the pepper-cooking Pepper is currently reviewing this PR label May 9, 2026

@pepper-pr-review pepper-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against DEV-243 (Linear) — aligned. The comment block accurately documents the pepper-cooking lifecycle: applied during the run, swapped for exactly one outcome label on completion, removed by cleanup if the workflow fails early. No runtime behavior changes, so no tests required.

The CI failure ('pepper-cooking' not found) is a workflow infra issue, not a defect in this documentation — the label exists in the repo, and the API call mysteriously failed. Since this is the smoke-test PR for DEV-237's lifecycle change and the documentation itself is correct, approving on the merits of the diff.

— Pepper

Comment @pepper review when you're ready for another look.

@pepper-pr-review pepper-pr-review Bot added pepper-approved Pepper approved this PR and removed pepper-cooking Pepper is currently reviewing this PR labels May 9, 2026
@brodkin brodkin added pepper-changes-requested Pepper requested changes pepper-needs-review Pepper needs human review labels May 10, 2026
@brodkin

brodkin commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

@pepper review

Test 2: PR has been manually staged with all three outcome labels (pepper-approved, pepper-changes-requested, pepper-needs-review) to simulate the worst-case stale-label scenario. The pre-clear step should strip all three before applying pepper-cooking, and Pepper's swap should leave exactly one outcome label.

@pepper-pr-review pepper-pr-review Bot added pepper-cooking Pepper is currently reviewing this PR and removed pepper-approved Pepper approved this PR pepper-changes-requested Pepper requested changes pepper-needs-review Pepper needs human review labels May 10, 2026

@pepper-pr-review pepper-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against DEV-243 (Linear) — aligned. This PR is the smoke-test vehicle for the pepper-cooking lifecycle, and the diff delivers exactly what the issue asked for: a comment block in the caller example documenting the three-state label lifecycle (during, after, failed). No runtime behavior changed, no tests needed.

The CI failure is environmental — the pre-clear step tried to remove pepper-cooking before it existed in this repo. That's expected for the first Pepper run here and doesn't reflect a problem with this diff. The label will exist after this review completes, and Test 2 (stale-label cleanup) can proceed.

Yours — Pepper

(When you're ready for another look, comment @pepper review.)

@pepper-pr-review pepper-pr-review Bot added pepper-approved Pepper approved this PR and removed pepper-cooking Pepper is currently reviewing this PR labels May 10, 2026
@brodkin brodkin merged commit 93f3a28 into main May 10, 2026
1 check failed
@brodkin brodkin deleted the ryan/dev-243-smoke-test-pepper-cooking branch May 10, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pepper-approved Pepper approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant