From e63daa5ec448ec8dffdf24227ff7a77d6605b9ad Mon Sep 17 00:00:00 2001 From: "Christian Y. Brenninkmeijer" Date: Tue, 5 May 2026 14:27:53 +0100 Subject: [PATCH 1/2] remove unused extra_allocations param --- .../interface/abstract_spinnaker_base.py | 2 +- .../utilities/report_functions/reports.py | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/spinn_front_end_common/interface/abstract_spinnaker_base.py b/spinn_front_end_common/interface/abstract_spinnaker_base.py index 06cbc619d..cad2b1754 100644 --- a/spinn_front_end_common/interface/abstract_spinnaker_base.py +++ b/spinn_front_end_common/interface/abstract_spinnaker_base.py @@ -1055,7 +1055,7 @@ def _report_router_info(self) -> None: with FecTimer("Router info report", TimerWork.REPORT) as timer: if timer.skip_if_cfg_false("Reports", "write_router_info_report"): return - routing_info_report([]) + routing_info_report() @final def _execute_basic_routing_table_generator(self) -> None: diff --git a/spinn_front_end_common/utilities/report_functions/reports.py b/spinn_front_end_common/utilities/report_functions/reports.py index 1dc4eec01..1e1ad2c83 100644 --- a/spinn_front_end_common/utilities/report_functions/reports.py +++ b/spinn_front_end_common/utilities/report_functions/reports.py @@ -466,14 +466,10 @@ def _sdram_usage_report_per_chip_with_timesteps( pass -def routing_info_report(extra_allocations: Iterable[ - Tuple[ApplicationVertex, str]] = ()) -> None: +def routing_info_report() -> None: """ Generates a report which says which keys is being allocated to each vertex. - - :param extra_allocations: - Extra vertex/partition ID pairs to report on. """ file_name = get_report_path("path_router_info_report") routing_infos = FecDataView.get_routing_infos() @@ -482,7 +478,6 @@ def routing_info_report(extra_allocations: Iterable[ vertex_partitions = OrderedSet( (p.pre_vertex, p.identifier) for p in get_app_partitions()) - vertex_partitions.update(extra_allocations) progress = ProgressBar(len(vertex_partitions), "Generating Routing info report") for pre_vert, part_id in progress.over(vertex_partitions): From 9bb27badd8fdc1022e5e610a75b04154a952bc7b Mon Sep 17 00:00:00 2001 From: "Christian Y. Brenninkmeijer" Date: Tue, 5 May 2026 14:33:44 +0100 Subject: [PATCH 2/2] remove unused imports --- spinn_front_end_common/utilities/report_functions/reports.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spinn_front_end_common/utilities/report_functions/reports.py b/spinn_front_end_common/utilities/report_functions/reports.py index 1e1ad2c83..82a81320d 100644 --- a/spinn_front_end_common/utilities/report_functions/reports.py +++ b/spinn_front_end_common/utilities/report_functions/reports.py @@ -15,7 +15,7 @@ import logging import os import time -from typing import Iterable, Optional, TextIO, Tuple +from typing import Optional, TextIO from spinn_utilities.config_holder import get_report_path from spinn_utilities.ordered_set import OrderedSet