fix(send): trigger validation on Max so Review enables immediately#2099
Merged
Conversation
The form uses react-hook-form's onChange mode, which only re-runs the
Zod schema when the Controller's TextInput fires onChange. handleMaxPress
just calls setValue('amount', maxAmount), which writes the value but
doesn't run validation, so isValid stays at its prior value (false if
the user hadn't typed first) and the Review button remains disabled.
Call trigger('amount') after setValue — matches the pattern already
used in CardRepayForm and RegularWithdrawForm for the same problem.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the Send modal, clicking Max without typing first leaves the Review button disabled.
handleMaxPresscallssetValue('amount', maxAmount), but react-hook-form'sonChangemode only re-runs the Zod schema when theController'sTextInputfiresonChange. ProgrammaticsetValuewrites the value into form state but doesn't re-validate, soformState.isValidstays at whatever it was before (i.e.,falseon fresh mount because the schema's "Please enter a valid amount" refine on an empty string already failed). The Review button readsdisabled={!selectedToken || !isValid}and stays disabled.Call
trigger('amount')aftersetValue— the same patternCardRepayForm.tsx:387-388andUnstake/RegularWithdrawForm.tsx:201-202already use for the identical case. ThesetAmountZustand call stays so the picker's downstream consumers see the new value.Test plan
https://claude.ai/code/session_013ovmPbLFvPhUCQq9qggyes
Generated by Claude Code