Context
Follow-up to PR #14 (Rules Refactor Part 1) which migrated aspiration rules to use events and the has_skill helper function.
The career rules should be similarly refactored to use the has_skill helper for consistency and maintainability.
Tasks
Reference
Example
See the aspiration rules in Rules.py (functions like _bodybuilder, _painter_extraordinaire, etc.) for examples of the pattern to follow.
Context
Follow-up to PR #14 (Rules Refactor Part 1) which migrated aspiration rules to use events and the
has_skillhelper function.The career rules should be similarly refactored to use the
has_skillhelper for consistency and maintainability.Tasks
has_skillhelper instead ofstate.has()directlyRules.py:22- TODO: Part Time Jobs?Rules.py:719- TODO check project manager career logic (Discord: https://discord.com/channels/731205301247803413/1079002955262480424/1403764728177758252)Rules.py:799- TODO relearn how the career locations send, and then refactor this to use has_skillReference
Example
See the aspiration rules in
Rules.py(functions like_bodybuilder,_painter_extraordinaire, etc.) for examples of the pattern to follow.