Skip to content

Source-map verification step missing for preview channel OTAs #53

Description

@Simplemart17

Context

Surfaced by Blind Hunter on PR #48 (story 9-9, finding D18).

Concern

SENTRY_AUTH_TOKEN is set as an EAS env var for both production and preview environments (per runbook §2.3). The OTA workflow's post-publish verification step (added in PR #48 review patch P8) asserts the source-map upload succeeded — but this fires for both channels uniformly.

The story-level verification step in runbook §3.2 ("First-Build Verification → Confirm Sentry source maps uploaded") is only documented for production. Preview builds will quietly succeed source-map upload (or quietly fail) without anyone noticing until a preview crash report is unreadable.

Suggested fix

Pick one:

  1. Add §3.2-equivalent for preview_bmad-output/planning-artifacts/runbooks/submit-and-deploy.md gets a sub-section confirming preview source-map upload after the first preview build / OTA.
  2. Drop SENTRY_AUTH_TOKEN from preview env — if no one debugs preview crashes via Sentry, save the upload cost. (Probably wrong — preview IS the verification surface.)
  3. Synthetic-crash test in CI — extend the post-publish step in ota-update.yml to actually fire a synthetic crash and grep Sentry for the deobfuscated stack. (Heavyweight; may be over-engineering for v1.)

Files

  • _bmad-output/planning-artifacts/runbooks/submit-and-deploy.md (§3.2)
  • .github/workflows/ota-update.yml

Pull request: #48

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtFollow-up work surfaced by code review or audit; not a current bug

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions