Skip to content

Cleanup: three minor decoded-but-dead fields with no downstream consumer #24

Description

@Nathan-D-R

Found during the 2026-07-24 cross-repo parity sweep. All three are read from the file into a struct but never consulted outside their own module's tests - likely intentional-but-forgotten parses rather than bugs. Bundled as one small issue rather than three.

  • ExternFunction::start_mass_da/end_mass_da (raw/extern_inf.rs:81-84, populated ~243-250) - mz range instead comes exclusively from _FUNCTNS.INF's FunctionInfo.mz_low/mz_high.
  • ChromChannel::source_type (raw/chroms.rs:23, populated line 85; BSM pump=4 vs column/sample device=1) - chromatogram_records_for (mzml.rs:317-350) only consults name/units/scale_f.
  • ScanIndexA::peak_count (raw/index.rs:30, a "confirmed" field per docs/format/03-func-idx.md:26) - never read outside test fixtures; could serve as a decode sanity-check.

Effort: small for all three - either wire them in for real use (e.g. peak_count as a decode assertion) or drop them if genuinely unneeded.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions