Skip to content

DIA/wideband scan-event flags decoded but never consumed #41

Description

@Nathan-D-R

Found during the 2026-07-24 cross-repo parity sweep.

ScanEventPreamble::is_dia() (crates/opentfraw/src/scan_event.rs:85) and ::is_wideband() (scan_event.rs:105) decode real per-scan bytes (byte 6 ms_power + byte 10 dependent flag; byte 32) with detailed doc comments, but neither is called anywhere outside their own definitions - not in to_msc_record/PrecursorInfo (mzml.rs:453), not in scan_filter::build_filter (scan_filter.rs:53), not in the Python scan()/iter_scans() dicts (opentfraw-py/src/lib.rs:497).

A DDA-vs-DIA flag is useful downstream metadata (e.g. distinguishing SWATH-like acquisitions) and costs nothing to surface since it's already decoded.

Effort: small wire-up.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions