Skip to content

Instrument model and acquisition timestamp are hardcoded placeholders, not resolved from file metadata #4

Description

@Nathan-D-R

Found while auditing metadata parity across the OpenMassSpec vendor stack (same pass that led to Sigilweaver/OpenMassSpec#3's streaming work, and to Sigilweaver/OpenTFRaw#24 / Sigilweaver/OpenTimsTDF#5 / Sigilweaver/OpenARaw#4 for the equivalent gaps in those readers). Reader::run_metadata in crates/opensxraw/src/reader.rs hardcodes both fields:

  • instrument: CvTerm::new("MS:1000121", "SCIEX instrument model") - this is a generic placeholder term, not anything resolved from the file. MS:1000121 is itself the generic "SCIEX instrument model" CV branch node, not a specific model.
  • start_timestamp: None - never populated.

Reader::open in the same file only opens the CFBF container to read the SampleSubtree/Sample1/Idx stream; it doesn't touch any other stream in the compound file. SCIEX .wiff files are CFBF containers with other named streams alongside Idx (method/acquisition info is typically stored elsewhere in the tree, e.g. under SampleSubtree or a top-level summary stream) - this needs investigation into what's actually present in the container before a specific field can be wired up, similar in spirit to what OpenWRaw does for Waters' header metadata. Same shape of gap as Sigilweaver/OpenARaw#4, bigger than the Thermo/Bruker fixes since nothing here is parsed yet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions