[Security] Fix locale-sensitive header redaction#7572
Conversation
Replaced toLocaleLowerCase() with toLowerCase() in sanitizedHeadersOutput to ensure consistent redaction of sensitive headers regardless of the system locale. Added a regression test simulating the Turkish locale issue.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Redaction of sensitive headers (like `AUTHORIZATION`) could be bypassed on systems with certain locales (e.g., Turkish) because `toLocaleLowerCase()` is non-deterministic for ASCII characters like 'I' (which becomes 'ı' in Turkish).
WHAT is this pull request doing?
This PR replaces `toLocaleLowerCase()` with `toLowerCase()` in `sanitizedHeadersOutput` to ensure consistent ASCII-based matching for HTTP headers regardless of the user's locale. It also adds a regression test that simulates the problematic locale behavior.
How to test your changes?
CI
Post-release steps
None.
Checklist
PR created automatically by Jules for task 14224719727929470904 started by @gonzaloriestra